Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexcurse: fix build with gcc7 #36663

Merged
merged 1 commit into from Mar 9, 2018
Merged

hexcurse: fix build with gcc7 #36663

merged 1 commit into from Mar 9, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 9, 2018

Motivation for this change

Fix build with gcc7.

/cc @cstrahan

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@GrahamcOfBorg build hexcurse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0
shrinking /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0/bin/hexcurse
gzipping man pages under /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0/bin
patching script interpreter paths in /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0
checking for references to /build in /nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0...
/nix/store/yxlyq860gq8qyavja52n1hkx1dg0dis2-hexcurse-1.60.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-hexcurse-1.60.0.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0
shrinking /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0/bin/hexcurse
gzipping man pages under /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0/bin 
patching script interpreter paths in /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0
checking for references to /tmp/nix-build-hexcurse-1.60.0.drv-0 in /nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0...
/nix/store/y3856kl025m5kaxn3amnh83a0kjvm03m-hexcurse-1.60.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘hexcurse-1.60.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/editors/hexcurse/default.nix:28 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Mar 9, 2018
@vcunat
Merge NixOS#36663: hexcurse: fix build with gcc7
0ce2f04
@vcunat vcunat merged commit 1fedf89 into NixOS:master Mar 9, 2018
vcunat added a commit that referenced this pull request Mar 9, 2018
@vcunat
Merge #36663: hexcurse: fix build with gcc7
7086687 
(cherry picked from commit 0ce2f04)
@pbogdan pbogdan deleted the hexcurse-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @Mic92 @GrahamcOfBorg @vcunat