rapid-photo-downloader: init at 0.9.9 #36621

jfrankenau · 2018-03-09T09:43:15Z

Motivation for this change

Rapid Photo Downloader is a quick and simple to use photo importer.

Things done

Add a few python packages needed for rapid-photo-downloader.

Currently, libgudev is manually overridden for rapid-photo-downloader to be built with gobjectIntrospection. It's probably better to wait for #35335 to be merged.

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2018-03-10T11:18:01Z

pkgs/development/python-modules/pymediainfo/default.nix

+
+  postPatch = ''
+    substituteInPlace pymediainfo/__init__.py \
+      --replace 'CDLL("libmediainfo.so.0")' 'CDLL("${libmediainfo}/lib/libmediainfo.so.0")' \


${stdenv.hostPlatform.extensions.sharedLibrary} instead of .so

Done. I've also replaced the library references for Darwin.

FRidh · 2018-03-10T13:50:58Z

pkgs/applications/graphics/rapid-photo-downloader/default.nix

+
+  buildInputs = [
+    gobjectIntrospection
+    (libgudev.overrideAttrs (oldAttrs: rec {


Can you add a comment explaining why this is needed?

Sure, no problem.

FRidh · 2018-03-10T13:51:27Z

pkgs/applications/graphics/rapid-photo-downloader/default.nix

+}:
+
+python3Packages.buildPythonApplication rec {
+  name    = "rapid-photo-downloader-${version}";


The name attribute is added by buildPython* and should therefore be removed. Instead, use

pname = "rapid-photo-downloader";

Yes, forget to do it for the main package as well. This detail could use some documentation in the Nixpkgs manual.

dotlambda · 2018-03-17T11:15:15Z

pkgs/applications/graphics/rapid-photo-downloader/default.nix

+  nativeBuildInputs = [ file intltool ];
+
+  buildInputs = [
+    gobjectIntrospection


Shouldn't this go into nativeBuildInputs?

Yes, you are right.

dotlambda · 2018-03-17T11:17:26Z

@GrahamcOfBorg build python2.pkgs.pymediainfo python3.pkgs.pymediainfo python2.pkgs.pyprind python3.pkgs.pyprind python2.pkgs.rawkit python3.pkgs.rawkit python2.pkgs.gphoto2 python3.pkgs.gphoto2

GrahamcOfBorg · 2018-03-17T11:18:55Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pymediainfo, python3.pkgs.pymediainfo, python2.pkgs.pyprind, python3.pkgs.pyprind, python2.pkgs.rawkit, python3.pkgs.rawkit, python2.pkgs.gphoto2, python3.pkgs.gphoto2

Partial log (click to expand)


========================== 53 passed in 0.99 seconds ===========================
/nix/store/crgpwajsqp9x5qkmzlszs8d0m04ac16z-python2.7-pymediainfo-2.2.1
/nix/store/2c1gca8w5f25950xw7qzb79mb5jszpwd-python3.6-pymediainfo-2.2.1
/nix/store/76gy7vna0lgwy25i6ivpl2ppxva2i96k-python2.7-PyPrind-2.11.2
/nix/store/2wxhwh47h4vwybyi55adzrdx5wav3cz0-python3.6-PyPrind-2.11.2
/nix/store/g13xsvlm0pdshk3gvmdhhrcdxq39470n-python2.7-rawkit-0.6.0
/nix/store/kba356l4zkvqnhxk1gxyyw2b1pwxx83w-python3.6-rawkit-0.6.0
/nix/store/1d9rbd2gxcq9rxpr1aanj6z5xfhq3g1v-python2.7-gphoto2-1.8.2
/nix/store/163mnfbsxqwasgcklfjxhbdydglfg1xa-python3.6-gphoto2-1.8.2

GrahamcOfBorg · 2018-03-17T11:19:04Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pymediainfo, python3.pkgs.pymediainfo, python2.pkgs.pyprind, python3.pkgs.pyprind, python2.pkgs.rawkit, python3.pkgs.rawkit, python2.pkgs.gphoto2, python3.pkgs.gphoto2

Partial log (click to expand)

/nix/store/37xd6gqvcah3qzm62s9yxgkvr21grw8i-python3.6-gphoto2-1.8.2/share/python-gphoto2/examples/set-camera-clock.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/143hazf8s5236kvprxlrgw9fdgzkrg0v-python3-3.6.4/bin/python"
checking for references to /build in /nix/store/37xd6gqvcah3qzm62s9yxgkvr21grw8i-python3.6-gphoto2-1.8.2...
/nix/store/175in3mq84vcbpb27zsna571pnrvn14r-python2.7-pymediainfo-2.2.1
/nix/store/1hyazmgnmcq3p4nwf59xdrkf1grm88zq-python3.6-pymediainfo-2.2.1
/nix/store/m2zj7wx5kgiwq60vpqqj732s1sxycbsk-python2.7-PyPrind-2.11.2
/nix/store/llzww59l9dmr8w6plrf2kibz3cmv1330-python3.6-PyPrind-2.11.2
/nix/store/1rkkkl2az8qa1w51xcymsm0zmkfv5gks-python2.7-rawkit-0.6.0
/nix/store/bla9rdkhqvawb99s98ip62lpfprrmmya-python3.6-rawkit-0.6.0
/nix/store/rc39xr7zcjlgf00l7zx40xjy4mday08n-python2.7-gphoto2-1.8.2
/nix/store/37xd6gqvcah3qzm62s9yxgkvr21grw8i-python3.6-gphoto2-1.8.2

dotlambda · 2018-03-17T16:40:47Z

pkgs/development/python-modules/pymediainfo/default.nix

+                'CDLL("${libmediainfo}/lib/libmediainfo${stdenv.hostPlatform.extensions.sharedLibrary}.0")'
+  '';
+
+  buildInputs = [ libmediainfo glibcLocales ];


libmediainfo should not be necessary here because it is referenced in postPatch. glibcLocales can go into checkInputs.

Done. The latter should also be corrected in the Nixpkgs Manual if I am not mistaken.

dotlambda

If you know how to run the tests in https://bazaar.launchpad.net/~dlynch3/rapid/zeromq_pyqt/files/head:/raphodo/tests/, that would be nice to have in checkPhase. But overall, seems fine.

dotlambda · 2018-03-18T10:09:28Z

pkgs/development/python-modules/pymediainfo/default.nix

+      --replace 'CDLL("libmediainfo.dylib")' \
+                'CDLL("${libmediainfo}/lib/libmediainfo${stdenv.hostPlatform.extensions.sharedLibrary}")' \
+      --replace 'CDLL("libmediainfo.so.0")' \
+                'CDLL("${libmediainfo}/lib/libmediainfo${stdenv.hostPlatform.extensions.sharedLibrary}.0")'


Is .0 necessary?

AFAIK this indicates the version number of the library which will be incremented on breaking changes. Thus I assume that this makes a difference.

FRidh · 2018-03-18T13:49:46Z

pkgs/applications/graphics/rapid-photo-downloader/default.nix

+
+  makeWrapperArgs = [
+    "--set GI_TYPELIB_PATH \"$GI_TYPELIB_PATH\""
+    "--set PYTHONPATH \"$PYTHONPATH\""


this will add build-time dependencies as run-time dependencies. Is the default wrapper not sufficient?

This was the only way I was able to make it work.

Makes sense, because the Python packages you've added are not included in propagatedBuildInputs. We use that attribute also for indicating they're run-time dependencies.

I've tried that before but then some modules like zmq cannot be found.

jfrankenau · 2018-03-19T17:34:43Z

@dotlambda, seeing as the tests are not included in the tarball, I believe those are not intended to be used downstream.

FRidh · 2018-03-20T15:34:22Z

@jfrankenau in my experience the average maintainer does not consider downstream distributors at all, so I would not dare making that assumption. Instead, I would say that, if upstream maintainers believe downstream distributors should not use their tests, that we should not package the software because of potential low quality.

jfrankenau · 2018-07-15T08:59:16Z

So, I've had a look at the tests and they seem to be outdated or need to be run interactively with some test data. I will see if I can get upstream to update those tests.

jfrankenau · 2018-07-17T07:27:52Z

@FRidh, so according to upstream the tests are not automated:

They are are a mix of transient tests used for only particular stages of development and benchmarking.

I've been using this PR without any problems so far and would be happy to see this merged. The override for libgudev has been resolved and I have updated the PR accordingly.

bjornfor · 2018-07-30T23:59:38Z

@FRidh: It seems all your comments have been adressed. I'm merging.

orivej · 2018-09-25T11:25:13Z

pymediainfo was broken by #46255

jfrankenau requested a review from FRidh as a code owner March 9, 2018 09:43

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Mar 9, 2018

FRidh requested changes Mar 10, 2018

View reviewed changes

jfrankenau force-pushed the init-rapid-photo-downloader branch from ba7c6b1 to 654076a Compare March 10, 2018 12:07

FRidh reviewed Mar 10, 2018

View reviewed changes

jfrankenau force-pushed the init-rapid-photo-downloader branch 4 times, most recently from e1f03e6 to d2a3621 Compare March 10, 2018 15:16

dotlambda reviewed Mar 17, 2018

View reviewed changes

jfrankenau force-pushed the init-rapid-photo-downloader branch from d2a3621 to 14012bc Compare March 17, 2018 16:36

dotlambda reviewed Mar 17, 2018

View reviewed changes

jfrankenau force-pushed the init-rapid-photo-downloader branch from 14012bc to 2ffeb20 Compare March 17, 2018 16:45

dotlambda reviewed Mar 18, 2018

View reviewed changes

FRidh reviewed Mar 18, 2018

View reviewed changes

jfrankenau added 6 commits July 14, 2018 20:32

pythonPackages.easygui: init at 0.98.1

852dca6

pythonPackages.pymediainfo: init at 2.3.0

2137f5b

pythonPackages.pyprind: init at 2.11.2

8ce4aa2

pythonPackages.rawkit: init at 0.6.0

e78a757

pythonPackages.gphoto2: init at 1.8.2

93f4bd8

rapid-photo-downloader: init at 0.9.9

e6f61bb

jfrankenau force-pushed the init-rapid-photo-downloader branch from 2ffeb20 to e6f61bb Compare July 14, 2018 18:46

bjornfor merged commit 09fcfb6 into NixOS:master Jul 30, 2018

jfrankenau deleted the init-rapid-photo-downloader branch July 31, 2018 06:53

jfrankenau mentioned this pull request Oct 15, 2018

rapid-photo-downloader: 0.9.10 -> 0.9.12 #48457

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rapid-photo-downloader: init at 0.9.9 #36621

rapid-photo-downloader: init at 0.9.9 #36621

jfrankenau commented Mar 9, 2018

FRidh Mar 10, 2018

jfrankenau Mar 10, 2018

FRidh Mar 10, 2018

jfrankenau Mar 10, 2018

FRidh Mar 10, 2018

jfrankenau Mar 10, 2018

dotlambda Mar 17, 2018

jfrankenau Mar 17, 2018

dotlambda commented Mar 17, 2018

GrahamcOfBorg commented Mar 17, 2018

GrahamcOfBorg commented Mar 17, 2018

dotlambda Mar 17, 2018

jfrankenau Mar 17, 2018 •

edited

dotlambda left a comment

dotlambda Mar 18, 2018

jfrankenau Mar 18, 2018

FRidh Mar 18, 2018

jfrankenau Mar 18, 2018

FRidh Jul 17, 2018

jfrankenau Jul 17, 2018 •

edited

jfrankenau commented Mar 19, 2018

FRidh commented Mar 20, 2018

jfrankenau commented Jul 15, 2018

jfrankenau commented Jul 17, 2018

bjornfor commented Jul 30, 2018

orivej commented Sep 25, 2018

rapid-photo-downloader: init at 0.9.9 #36621

rapid-photo-downloader: init at 0.9.9 #36621

Conversation

jfrankenau commented Mar 9, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Mar 17, 2018

GrahamcOfBorg commented Mar 17, 2018

GrahamcOfBorg commented Mar 17, 2018

Choose a reason for hiding this comment

jfrankenau Mar 17, 2018 • edited

Choose a reason for hiding this comment

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfrankenau Jul 17, 2018 • edited

Choose a reason for hiding this comment

jfrankenau commented Mar 19, 2018

FRidh commented Mar 20, 2018

jfrankenau commented Jul 15, 2018

jfrankenau commented Jul 17, 2018

bjornfor commented Jul 30, 2018

orivej commented Sep 25, 2018

jfrankenau Mar 17, 2018 •

edited

jfrankenau Jul 17, 2018 •

edited