Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpfr: 3.1.6 -> 4.0.1 #36620

Closed
wants to merge 1 commit into from
Closed

mpfr: 3.1.6 -> 4.0.1 #36620

wants to merge 1 commit into from

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Mar 9, 2018

Semi-automatic update. These checks were done:

  • built on NixOS
  • Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
  • found 4.0.1 with grep in /nix/store/gpsg0bpw02hpc8hddjnirpnvsp7n4ak8-mpfr-4.0.1
  • found 4.0.1 in filename of file in /nix/store/gpsg0bpw02hpc8hddjnirpnvsp7n4ak8-mpfr-4.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/fhdafzxl0mbh3l9jv4faac26zlhx5j84-mpfr-4.0.1/lib
patching script interpreter paths in /nix/store/fhdafzxl0mbh3l9jv4faac26zlhx5j84-mpfr-4.0.1
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qda70vlmy7j6j3z9gm9zngjfn73px4bz-mpfr-4.0.1-dev/lib
patching script interpreter paths in /nix/store/qda70vlmy7j6j3z9gm9zngjfn73px4bz-mpfr-4.0.1-dev
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/d2w1p4abw4kyqpgsp144ac2h6m9f4ql9-mpfr-4.0.1-doc
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/8jb1mrxpn7q97s7i4ljjcwanin7cl92d-mpfr-4.0.1-info
/nix/store/fhdafzxl0mbh3l9jv4faac26zlhx5j84-mpfr-4.0.1

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/877aai9w1zklhk68wnbjkfwypgkpkfrk-pkg-config-0.29.2.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/szrc2wy2p6kacxdlhs9ixdafakr1lhrf-gmp-6.1.2.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/hjya1idilzrqzyagjlf4k664riivfwrz-openssl-1.0.2n.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/qcl6rwgnqqlhirvypb68ahxijwc514m9-libkrb5-1.15.2.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/55xfknznhjbll5s0sfcjrminzk4n2jjx-libssh2-1.8.0.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/6h0l79b46nddq7df96zn8qxcp9q1qhgc-nghttp2-1.24.0.drv’: 6 dependencies couldn't be built
cannot build derivation ‘/nix/store/yp0r6hkwl8yv09121h0s5yrjs6zqksk1-curl-7.58.0.drv’: 8 dependencies couldn't be built
cannot build derivation ‘/nix/store/v9q42fzxzs5kkqi88wgpkmlz73yjywnz-mpfr-4.0.1.tar.xz.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/rk6m5zinll6ki33f1jsif9mdqc1ys0x5-mpfr-4.0.1.drv’: 4 dependencies couldn't be built
error: build of ‘/nix/store/rk6m5zinll6ki33f1jsif9mdqc1ys0x5-mpfr-4.0.1.drv’ failed

@7c6f434c
Copy link
Member

7c6f434c commented Mar 9, 2018

Stdenv change. Definitely should go into staging. Not sure if it should be an upgrade or an addition of mpfr4 with old version becoming mpfr3 and mpfr being mpfr4…

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/nac0fniaj53z976grridz3a1lq7c83hi-mpfr-4.0.1-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/ml8xmp9n82yfm5zb1jbmvgn8wf1j4f5j-mpfr-4.0.1-doc
strip is /nix/store/j02m5zw9la1pi9m96c6g3bc7ciag21px-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/ml8xmp9n82yfm5zb1jbmvgn8wf1j4f5j-mpfr-4.0.1-doc
checking for references to /build in /nix/store/ml8xmp9n82yfm5zb1jbmvgn8wf1j4f5j-mpfr-4.0.1-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/0r1w4a5v7f486jyqfik3g6hg1rzi9lz2-mpfr-4.0.1-info
strip is /nix/store/j02m5zw9la1pi9m96c6g3bc7ciag21px-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0r1w4a5v7f486jyqfik3g6hg1rzi9lz2-mpfr-4.0.1-info
checking for references to /build in /nix/store/0r1w4a5v7f486jyqfik3g6hg1rzi9lz2-mpfr-4.0.1-info...
/nix/store/slfhs2skviqs4nkkn6m81yd7whh53vi0-mpfr-4.0.1

@ryantm
mpfr: 3.1.6 -> 4.0.1
efdf91d 
Semi-automatic update. These checks were done:

- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 4.0.1 with grep in /nix/store/gpsg0bpw02hpc8hddjnirpnvsp7n4ak8-mpfr-4.0.1
- found 4.0.1 in filename of file in /nix/store/gpsg0bpw02hpc8hddjnirpnvsp7n4ak8-mpfr-4.0.1
@ryantm ryantm changed the base branch from master to staging March 9, 2018 15:56
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

[ 51%] Building CXX object lib/Frontend/Rewrite/CMakeFiles/clangRewriteFrontend.dir/InclusionRewriter.cpp.o
[ 51%] Building CXX object lib/Frontend/Rewrite/CMakeFiles/clangRewriteFrontend.dir/RewriteMacros.cpp.o
[ 51%] Building CXX object lib/Frontend/Rewrite/CMakeFiles/clangRewriteFrontend.dir/RewriteModernObjC.cpp.o
[ 51%] Building CXX object lib/Frontend/Rewrite/CMakeFiles/clangRewriteFrontend.dir/RewriteObjC.cpp.o
[ 51%] Building CXX object lib/Frontend/Rewrite/CMakeFiles/clangRewriteFrontend.dir/RewriteTest.cpp.o
building of '/nix/store/qr07kib8jg14akbm45ajbkxfqvjvv2pw-clang-5.0.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/dzbrfaj1lk2nb73p2ijlscbhayi06b9f-clang-wrapper-5.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3wpgrjsd3y186f80j92bjzi2hd76g5fj-stdenv-darwin.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/l861l6767fh9kpv46l2cz61nsbgj1prd-mpfr-4.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/l861l6767fh9kpv46l2cz61nsbgj1prd-mpfr-4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/scy2b1l8ds5cbsqd9m89wyz0l25gnlla-diffutils-3.6.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/q0hq8k0v1jhn4dvyh7s1yfzlrxgv5wah-ed-1.14.2.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/fxigdglmgip1i6cfvg5xp5gc2lkpa8nv-findutils-4.6.0.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/k6vlqby3hrs6mz2n73qazmxk0ki6s4l8-gcc-wrapper-7.3.0.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/ns9kzdc62k2pfxd44lcj2ia40dlhjfii-patch-2.7.6.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/1mfcfg5l8d3ahf6rs39ljl4mp8brwmsp-stdenv-linux.drv’: 23 dependencies couldn't be built
cannot build derivation ‘/nix/store/z7ki6w425f0kgj2rk3av1n6mbf58pxz3-gnum4-1.4.18.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/8gvayndrxjyxkdrvczinyrkd5z8j4rv2-gmp-6.1.2.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/mrixwxxg5xxsiny2hcr2nwjg94bj3m68-mpfr-4.0.1.drv’: 3 dependencies couldn't be built
error: build of ‘/nix/store/mrixwxxg5xxsiny2hcr2nwjg94bj3m68-mpfr-4.0.1.drv’ failed

@7c6f434c
Copy link
Member

7c6f434c commented Mar 9, 2018

Build failure is just a timeout.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/bv1nszlaabk4vpdjldycjparhbxl6qhb-mpfr-4.0.1-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/wva0jnm7xz81ylzmql4kwwl8x4jxw8jh-mpfr-4.0.1-doc
strip is /nix/store/05lx39m42scyld3ilwq1k2lmg4y424cm-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/wva0jnm7xz81ylzmql4kwwl8x4jxw8jh-mpfr-4.0.1-doc
checking for references to /build in /nix/store/wva0jnm7xz81ylzmql4kwwl8x4jxw8jh-mpfr-4.0.1-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/f3n47dp1al9y7rp3lyvka6bf1bin47cw-mpfr-4.0.1-info
strip is /nix/store/05lx39m42scyld3ilwq1k2lmg4y424cm-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/f3n47dp1al9y7rp3lyvka6bf1bin47cw-mpfr-4.0.1-info
checking for references to /build in /nix/store/f3n47dp1al9y7rp3lyvka6bf1bin47cw-mpfr-4.0.1-info...
/nix/store/wmlb7m055cvm67fhr80cwjlhmmb95xra-mpfr-4.0.1

@timokau
Copy link
Member

timokau commented Apr 26, 2018

Should we maybe create a hydra jobset to test this upgrade? The major version changelog is here. Skimming it, this seems to be potentially interesting:

  • MPFR now depends on GMP 5.0+ instead of 4.1+.
  • API change: Applications that call GMP's mp_set_memory_functions function to change the allocators must first call the new function mpfr_mp_memory_cleanup in all threads where MPFR is potentially used; this new function is currently equivalent to mpfr_free_cache. The reason is that the way memory allocation is done by MPFR has changed (again), so that the current GMP allocators are used (since for some applications, the old allocators may become invalid). Note: Freeing the caches like this might have a performance impact on some particular applications; if this is an issue, this could be handled for a future MPFR version.
  • The behavior of the mpfr_set_exp function changed, as it could easily yield undefined behavior in some cases (this modifies both the API and the ABI).
  • In function mpfr_urandom, the next random state no longer depends on the current exponent range and the rounding mode. The exceptions due to the rounding of the random number are now correctly generated, following the uniform distribution.
  • Old, deprecated macros mpfr_add_one_ulp and mpfr_sub_one_ulp removed. The mpfr_next* functions should be used instead.
  • Dropped K&R C compatibility.

@timokau
Copy link
Member

timokau commented Apr 26, 2018

One datapoint: arch only packages mpfr 4.0.1, so it should not be very problematic.

@timokau timokau mentioned this pull request Apr 26, 2018
Merged
8 tasks
@timokau
Copy link
Member

timokau commented Apr 26, 2018

While rebuilding sage with this update applied, I noticed that mpfi needs to be updated too. Those two libraries seem to be tightly connected, so I created a PR updating them together: #39578

@timokau
Copy link
Member

timokau commented Apr 27, 2018

This can be closed (#39578).

@7c6f434c 7c6f434c closed this Apr 27, 2018
@ryantm ryantm deleted the auto-update/mpfr branch April 27, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@orivej orivej Awaiting requested review from orivej

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantm @GrahamcOfBorg @7c6f434c @timokau