New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for a swtich to libcardiacarrest
#36657
Conversation
@GrahamcOfBorg build apulse pamixer |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
dac233d
to
079bbd3
Compare
@GrahamcOfBorg build libcardiacarrest libpressureaudio |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Ok, so I didn't screw up any hashes. The firefoxes I did build and test locally. LGTM. |
079bbd3
to
64e50c1
Compare
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
@@ -7,8 +10,8 @@ stdenv.mkDerivation rec { | |||
src = fetchFromGitHub { | |||
owner = "i-rinat"; | |||
repo = "apulse"; | |||
rev = "v${version}"; | |||
sha256 = "16l278q0czca2794fj388ql6qn1zrw24a0p6k7bayrrf5h32fdzd"; | |||
rev = "602b3a02b4b459d4652a3a0a836fab6f892d4080"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't version gain a suffix in that case?
./env_var_for_system_dir.patch | ||
|
||
# this one is actually an omnipresent bug | ||
./fix-pa-context-connect-retval.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a link to upstream (Mozilla) issue?
Shouldn't version gain a suffix in that case?
Well, probably. But I have no idea about the protocol here. Should I add a "+" there? Something else?
Could you please add a link to upstream (Mozilla) issue?
I have not reported it yet. I can move that patch back to the stash, if you feel uncomfortable about it. `libcardiacarrest` will handle it anyway.
|
Re: version: I think a period (or maybe Re: Firefox: I don't want any resolution, I want a link to check a few months later. I.e. a minimal report — yours or preexisting — is enough, the upstream discussion can go with its own pace afterwards. |
This adds LOG_TO_STDERR support and uses it for tracing.
This is optional (`libcardiacarrest` has a workaround for this bug because there's `firefox-bin` that I can't fix), but with this applied things are a bit smoother.
64e50c1
to
23e2ea9
Compare
Both done.
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
And thanks!
|
Motivation for this change
Side-effect of me building everything with
libcardiacarrest
instead oflibpulseaudio
(see #35374). This patchset continues adding new parts needed for the switch and fixing existing parts that would break after the switch. Also some OCD fixes.This part should not cause a mass rebuild.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)