Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.lib.haskellSrc2nix: add extraCabal2nixOptions #36652

Merged
merged 1 commit into from Mar 9, 2018
Merged

haskell.lib.haskellSrc2nix: add extraCabal2nixOptions #36652

merged 1 commit into from Mar 9, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 9, 2018 •
edited

Motivation for this change

This lets you pass extra options to cabal2nix, for example to enable a flag that affects the set of dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth roberth requested a review from peti as a code owner March 9, 2018 13:59
@peti peti merged commit 90b3949 into NixOS:master Mar 9, 2018
@roberth roberth deleted the cabal2nix-extra-options branch March 9, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @peti @GrahamcOfBorg