Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler: fix build on Darwin #35667

Merged
merged 1 commit into from Mar 17, 2018
Merged

poppler: fix build on Darwin #35667

merged 1 commit into from Mar 17, 2018

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 26, 2018

The build failed before. Untested ATM!

@vcunat vcunat added 6.topic: darwin Running or building packages on Darwin 2.status: work-in-progress labels Feb 26, 2018
@vcunat vcunat added this to the 18.03 milestone Feb 26, 2018
@vcunat vcunat mentioned this pull request Feb 26, 2018
Merged
8 tasks
@vbgl
Copy link
Contributor

vbgl commented Mar 16, 2018

poppler 0.62 fails to build on darwin:

[3/114] Building CXX object CMakeFiles/poppler.dir/goo/GooHash.cc.o
FAILED: CMakeFiles/poppler.dir/goo/GooHash.cc.o
/nix/store/dhbvzckljywvqls1wcq373dmr34nbpyj-clang-wrapper-5.0.1/bin/clang++  -DUSE_OPENJPEG2 -Dpoppler_EXPORTS -I../ -I../fofi -I../goo -I../poppler -I. -Ipoppler -I/nix/store/yz2da4ynapy552wkkhim9vcnzs0p9kny-fontconfig-2.12.1-dev/include -I/nix/store/fqh4n07a6s95b4j9g6zi2mnif5l6id9a-freetype-2.7.1-dev/include/freetype2 -I/nix/store/4g8dcp0ddp8ch2by42rbjrmn0pc3m6gd-zlib-1.2.11-dev/include -I/Library/Frameworks/UnixImageIO.framework/Headers -I/nix/store/ldc346z91bv4qkykzvlcva1iahdh3vfi-openjpeg-2.3.0-dev/include/openjpeg-2.3 -O3 -DNDEBUG -arch x86_64 -fPIC -MD -MT CMakeFiles/poppler.dir/goo/GooHash.cc.o -MF CMakeFiles/poppler.dir/goo/GooHash.cc.o.d -o CMakeFiles/poppler.dir/goo/GooHash.cc.o -c ../goo/GooHash.cc
../goo/GooHash.cc:358:12: error: use of undeclared identifier 'nullptr'
    return nullptr;

I just confirmed locally that this patch fixes the build of poppler_min and poppler on darwin. Are there any reasons not to merge this?

@jtojnar jtojnar mentioned this pull request Mar 17, 2018
Merged
8 tasks
@mpickering
Copy link
Contributor

Can someone merge this patch please?

@7c6f434c 7c6f434c merged commit ed41655 into NixOS:staging Mar 17, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Mar 17, 2018

Weird, Poppler is setting CXX_STANDARD variable:

https://cgit.freedesktop.org/poppler/poppler/tree/CMakeLists.txt?id=poppler-0.62.0#n37

@vcunat vcunat deleted the p/poppler-darwin branch March 18, 2018 08:31
@mpickering mpickering mentioned this pull request Mar 18, 2018
Merged
8 tasks
@mnacamura mnacamura mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vcunat @vbgl @mpickering @jtojnar @7c6f434c @GrahamcOfBorg