Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_4: fix cosmetic issue in help output #35674

Merged
merged 1 commit into from Feb 26, 2018
Merged

llvm_4: fix cosmetic issue in help output #35674

merged 1 commit into from Feb 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 26, 2018

Fix bug in help output.

Can be observed in programs like "llvm-link".

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
llvm_4: fix cosmetic issue in help output
435288c 
Can be observed in programs like "llvm-link".
@dtzWill dtzWill merged commit 3092659 into NixOS:staging Feb 26, 2018
@dtzWill dtzWill deleted the fix/llvm-4-cmdline-help branch February 26, 2018 14:57
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/wwac3fvfnkmzdvhikgmsr9zp358vl8ad-llvm-4.0.1/lib  /nix/store/wwac3fvfnkmzdvhikgmsr9zp358vl8ad-llvm-4.0.1/bin
patching script interpreter paths in /nix/store/wwac3fvfnkmzdvhikgmsr9zp358vl8ad-llvm-4.0.1
checking for references to /build in /nix/store/wwac3fvfnkmzdvhikgmsr9zp358vl8ad-llvm-4.0.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/9v0azx9fhnix5s08phn0j7cxxxl8fc43-llvm-4.0.1-lib
shrinking /nix/store/9v0azx9fhnix5s08phn0j7cxxxl8fc43-llvm-4.0.1-lib/lib/libLLVM-4.0.so
strip is /nix/store/ggjc1mfsicyq31xlg5d51hl9lc21wxnv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9v0azx9fhnix5s08phn0j7cxxxl8fc43-llvm-4.0.1-lib/lib
patching script interpreter paths in /nix/store/9v0azx9fhnix5s08phn0j7cxxxl8fc43-llvm-4.0.1-lib
checking for references to /build in /nix/store/9v0azx9fhnix5s08phn0j7cxxxl8fc43-llvm-4.0.1-lib...
/nix/store/wwac3fvfnkmzdvhikgmsr9zp358vl8ad-llvm-4.0.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/ssd50j6flj2l6x8wqwcd8v07fyl3y8ig-apple-framework-CoreGraphics.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/kf8sxh3b142vrfsgn82scwbrzmw4779m-apple-framework-CoreServices.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/lvw4l3z4f3lhh8wq92mlw405rbyzbvk9-apple-framework-CoreText.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/h7s6ing9gngqdzxm9wss1ak1bk6lagrc-apple-framework-ImageIO.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/6s418llxxmp7fpsnpla0qmx11jnmwfmi-apple-framework-ApplicationServices.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/vyj5pyhrxb95x9145zp52xb73iknkg85-libuv-1.19.1.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/aa5821mjbv1i7plpjyqij1rsjz24aqp4-cmake-3.10.2.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/f50znqp9dhhgapkrn1n0yqb58mcm64an-libc++abi-4.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/sc2h8v9lbpidf82q4sgav3b53jxwbm1w-llvm-4.0.1.drv': 9 dependencies couldn't be built
error: build of '/nix/store/sc2h8v9lbpidf82q4sgav3b53jxwbm1w-llvm-4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

[ 48%] Building LanaiGenSubtargetInfo.inc...
[ 48%] Updating LanaiGenSubtargetInfo.inc...
[ 48%] Built target LanaiCommonTableGen
Scanning dependencies of target LLVMLanaiCodeGen
[ 48%] Building CXX object lib/Target/Lanai/CMakeFiles/LLVMLanaiCodeGen.dir/LanaiAsmPrinter.cpp.o
[ 48%] Building CXX object lib/Target/Lanai/CMakeFiles/LLVMLanaiCodeGen.dir/LanaiDelaySlotFiller.cpp.o
[ 48%] Building CXX object lib/Target/Lanai/CMakeFiles/LLVMLanaiCodeGen.dir/LanaiFrameLowering.cpp.o
[ 48%] Building CXX object lib/Target/Lanai/CMakeFiles/LLVMLanaiCodeGen.dir/LanaiInstrInfo.cpp.o
building of ‘/nix/store/jphpnkssr438h7y6kvpbgix4yr2crm68-llvm-4.0.1.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/jphpnkssr438h7y6kvpbgix4yr2crm68-llvm-4.0.1.drv’ failed

@dtzWill
Copy link
Member Author

dtzWill commented Feb 26, 2018

That aarch64 builder is a BEAST! :D

vcunat pushed a commit that referenced this pull request Mar 7, 2018
@dtzWill @vcunat
Merge pull request #35674 from dtzWill/fix/llvm-4-cmdline-help
70e1ebe 
llvm_4: fix cosmetic issue in help output

(cherry picked from commit 3092659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg