Revert "Fixed yielded arrays of 1 element bug when using Enumerator::… #5045
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Yielder#first" This reverts commit cb25efe.
|
Please disregard - I mistakenly had the previous version built on my system when I tested the older test case. This revert causes a regression. Closing. |
|
@glucero we appreciate you looking into this. Block array dereferencing logic is complicated...to say the least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #5044
This reverts commit cb25efe.
The code reverted in this pull request comes from #2376 and the related issue #2458
The test case in 2376 still works with the code removed.