Add hpx::iostreams::ostream overload to format_to #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Fixes" problem of the hpx::iostreams::ostream << operator not being called when the hpx::iostreams::ostream is used as a std::ostream.
msimberg
changed the title
|
For the records, the actual problem is that |
hkaiser
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3013.
Proposed Changes
hpx::util::format_totaking ahpx::iostreams::ostreamto make sure that the correct operators (<<) are called.Any background context you want to provide?
When a
hpx::iostreams::ostreamis used as astd::ostreamthe correct virtual functions are not called, thus bypassing locks that are supposed to be taken in thehpx::iostreams::ostreamimplementation (base class functions are not virtual?). A proper fix would make sure the correct functions are called, but at the moment I have no fix for that.