fix error handling and return code #35017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qknight: I'm unable to reproduce this, $ nix-prefetch-git https://golang.org/x/net --rev 9831f2c3ac1068a78f50
Initialized empty Git repository in /tmp/git-checkout-tmp-AREolhSA/net-9831f2c/.git/
fatal: https://golang.org/x/net/info/refs not valid: is this a git repository?
fatal: https://golang.org/x/net/info/refs not valid: is this a git repository?
Unable to checkout 9831f2c3ac1068a78f50 from https://golang.org/x/net.
$ echo $?
1
$ You mention Do you have the output without these changes applied, but using |
qknight
commented
Feb 19, 2018
| echo 1>&2 "Unable to checkout $hash$ref from $url." | ||
| exit 1 | ||
| ) | ||
| exit_status=$(checkout_ref "$hash" "$ref" || checkout_hash "$hash" "$ref") |
There was a problem hiding this comment.
i'm not sure if this is the proper solution but it seems to work. can someone confirm this is correct code?
|
@aszlig i've update the example and you should now be able to see that it is broken and that this PR fixes it. |
10 tasks
|
What is the status of this pull request? |
|
Closing due to lack of activity, feel free re-open this if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
there is a bug in
nix-prefetch-gitwhich makes our implementation ofdep2niximpossible, since the error handling is not working at all.the cause for the problem is that
https://golang.org/x/netis not a git repository at all and thereforenix-prefetch-gitshould fail with an exit code != 0 which is not the case.the output before the change A
the output before the change A (with --quiet)
WARNING: exit code should still be 1 and not 0!
the output after the change B
the output after the change B (with --quiet)
Things done