Filter out "null" from nix-buffer packages #34896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null packages cause an error
|
I have no idea how this got merged. |
|
@matthewbauer, it looks pretty straight forward - would you like to err on the side of caution and have me revert it? |
|
@peterhoeg Not sure why it's marked as you, I merged it. |
|
That is bizarre. I thought I had botched a merge job of some kind. Anyway, if this bug continues my commit stats are going through the roof! |
|
I think commit stats are from commits and commits are recorded correctly… |
|
Dammit, so much for my plans to become "Committer of the Year". Oh well, I guess I'm just going to have to go about it the old-fashioned way.... By bribing someone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null packages cause an error. This adds a filter to prevent "makeSearchPath" from sending an error.
We can't guarantee that every package is going to be nonnull in some cases. See reflex-frp/reflex-platform#240
/cc @shlevy