yokadi: init at 1.1.1 #34900

npavlinek · 2018-02-12T16:49:37Z

Motivation for this change

Yokadi is an easy-to-use TODO manager.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-02-12T17:50:52Z

pkgs/applications/misc/yokadi/default.nix

+
+python3Packages.buildPythonApplication rec {
+  name = "yokadi-${version}";
+  version = "1.1.1";


Please specify only pname and version, no name.

dotlambda · 2018-02-12T17:51:20Z

pkgs/applications/misc/yokadi/default.nix

@@ -0,0 +1,26 @@
+{ stdenv, fetchurl, python3Packages }:


Don't pass python3Packages, but rather the packages directly.

dotlambda · 2018-02-12T17:51:40Z

pkgs/top-level/all-packages.nix

@@ -18200,6 +18200,8 @@ with pkgs;

  inherit (gnome3) yelp;

+  yokadi = callPackage ../applications/misc/yokadi {};


python3Packages.callPackage

dotlambda · 2018-02-12T17:52:48Z

pkgs/applications/misc/yokadi/default.nix

+    description = "A command line oriented, sqlite powered, todo-list";
+    homepage = https://yokadi.github.io/index.html;
+    license = licenses.gpl3;
+    maintainers = maintainers.nipav;


This should be a list.

So here I'm guessing that maintainers needs to be set to a list, such as this maintainers = [ maintainers.nipav ];?

Ok, thank you. I'll fix everything else and push.

rasendubi · 2018-02-12T19:24:12Z

pkgs/applications/misc/yokadi/default.nix

+  sqlalchemy, setproctitle, icalendar, pycrypto }:
+
+buildPythonApplication rec {
+  pname = "yokadi-${version}";


pname should not include version:

pname = "yokadi";

They are mixed in together in

nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix

Line 14 in 4a2340f

{ name ? "${attrs.pname}-${attrs.version}"

.

(Don't forget to fix fetchurl after this change.)

rasendubi · 2018-02-12T19:28:16Z

pkgs/applications/misc/yokadi/default.nix

+  meta = with stdenv.lib; {
+    description = "A command line oriented, sqlite powered, todo-list";
+    homepage = https://yokadi.github.io/index.html;
+    license = licenses.gpl3;


It should be licenses.gpl3Plus. (See https://github.com/agateau/yokadi/blob/master/yokadi/__init__.py#L6)

npavlinek · 2018-02-12T19:43:12Z

Ok, fixed. @rasendubi

dotlambda · 2018-02-12T19:51:33Z

@GrahamcOfBorg build yokadi

GrahamcOfBorg · 2018-02-12T19:52:10Z

Success on aarch64-linux (full log)

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'version'
writing manifest file 'yokadi.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/52y7kh1d0c4i86v1nnl87458cpbbz7jm-yokadi-1.1.1

dotlambda · 2018-02-12T19:53:37Z

Ran 0 tests in 0.001s

Please specify an appropriate checkPhase. If no tests are implement, please set doCheck = false and add a comment stating why they are disabled.

rasendubi · 2018-02-13T08:41:17Z

@GrahamcOfBorg build yokadi

GrahamcOfBorg · 2018-02-13T08:41:32Z

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1
gzipping man pages under /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1/lib  /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1/bin 
patching script interpreter paths in /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1
checking for references to /tmp/nix-build-yokadi-1.1.1.drv-0 in /nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1...
wrapping `/nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1/bin/yokadid'...
wrapping `/nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1/bin/yokadi'...
/nix/store/yfvkmfb8dimfq9chcsrysb8glbz7842p-yokadi-1.1.1

GrahamcOfBorg · 2018-02-13T08:41:45Z

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1
gzipping man pages under /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1/lib  /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1/bin
patching script interpreter paths in /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1
checking for references to /build in /nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1...
wrapping `/nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1/bin/yokadi'...
wrapping `/nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1/bin/yokadid'...
/nix/store/r1485c9h8ywks318a6nwnhnhvkrkscsl-yokadi-1.1.1

rasendubi · 2018-02-13T08:43:02Z

@nipav Thanks for your contribution!

dotlambda requested changes Feb 12, 2018

View reviewed changes

npavlinek force-pushed the master branch from b116d92 to 06c939b Compare February 12, 2018 19:03

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 12, 2018

rasendubi reviewed Feb 12, 2018

View reviewed changes

npavlinek force-pushed the master branch from 06c939b to 7132b77 Compare February 12, 2018 19:42

yokadi: init at 1.1.1

0601c4e

npavlinek force-pushed the master branch from 7132b77 to 0601c4e Compare February 12, 2018 20:02

rasendubi approved these changes Feb 13, 2018

View reviewed changes

rasendubi merged commit 1313324 into NixOS:master Feb 13, 2018

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yokadi: init at 1.1.1 #34900

yokadi: init at 1.1.1 #34900

npavlinek commented Feb 12, 2018 •

edited

dotlambda Feb 12, 2018

dotlambda Feb 12, 2018

dotlambda Feb 12, 2018

dotlambda Feb 12, 2018

npavlinek Feb 12, 2018

dotlambda Feb 12, 2018

npavlinek Feb 12, 2018

rasendubi Feb 12, 2018

rasendubi Feb 12, 2018

rasendubi Feb 12, 2018

npavlinek commented Feb 12, 2018

dotlambda commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

dotlambda commented Feb 12, 2018

rasendubi commented Feb 13, 2018

GrahamcOfBorg commented Feb 13, 2018

GrahamcOfBorg commented Feb 13, 2018

rasendubi commented Feb 13, 2018

		@@ -18200,6 +18200,8 @@ with pkgs;

		inherit (gnome3) yelp;

		yokadi = callPackage ../applications/misc/yokadi {};

yokadi: init at 1.1.1 #34900

yokadi: init at 1.1.1 #34900

Conversation

npavlinek commented Feb 12, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

npavlinek commented Feb 12, 2018

dotlambda commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

dotlambda commented Feb 12, 2018

rasendubi commented Feb 13, 2018

GrahamcOfBorg commented Feb 13, 2018

GrahamcOfBorg commented Feb 13, 2018

rasendubi commented Feb 13, 2018

npavlinek commented Feb 12, 2018 •

edited