ripgrep: 0.7.1 -> 0.8.0, install shell completions #34888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ripgrep |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
bkchr
reviewed
Feb 12, 2018
|
|
||
| preFixup = '' | ||
| mkdir -p "$out/man/man1" | ||
| cp "$src/doc/rg.1" "$out/man/man1" | ||
| cp target/release/build/ripgrep-*/out/rg.1 "$out/man/man1/" |
There was a problem hiding this comment.
I build with your changes locally and the manpage can be found in the following path: ./source/target/release/build/ripgrep-f969427e20cd23eb/out/rg.1.txt
There was a problem hiding this comment.
Manpage should be built from this file with a2x --no-xmllint --doctype manpage --format manpage rg.1.txt (see https://github.com/BurntSushi/ripgrep/blob/master/build.rs#L73:L97).
There was a problem hiding this comment.
Ahh yeah :( Any idea why the correct file is not created?
There was a problem hiding this comment.
Unable to reproduce on NixOS and on other Linux distribution
There was a problem hiding this comment.
Hmm, for me it still does not work. If you want, I can look at it tomorrow.
There was a problem hiding this comment.
I messed up. Sandboxing was actually disabled 🤦♂️
Now I can repro.
There was a problem hiding this comment.
I got it to work with asciidocFull instead of asciidoc (#34967). asciidoc should also be added to buildInputs.
There was a problem hiding this comment.
Why can't it be a native input? It's a build time dependency.
There was a problem hiding this comment.
Yeah you're right, it should be a native input.
jlesquembre
reviewed
Feb 12, 2018
pkgs/tools/text/ripgrep/default.nix
Outdated
|
|
||
| mkdir -p "$out/share/"{bash-completion/completions,fish/completions,zsh/site-functions} | ||
| cp target/release/build/ripgrep-*/out/rg.bash "$out/share/bash-completion/completions/" | ||
| cp target/release/build/ripgrep-*/out/rg.fish "$out/share/fish/completions/" |
There was a problem hiding this comment.
Can you install the fish completions on /share/fish/vendor_completions.d/ ? It's where they are expected:
nixpkgs/nixos/modules/programs/fish.nix
Lines 168 to 172 in 57707ea
|
@GrahamcOfBorg build ripgrep |
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build ripgrep |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build ripgrep |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
LnL7
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md#080-2017-02-11
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)