Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change container name in Testing #177

Merged
merged 2 commits into from Feb 19, 2018
Merged

Conversation

Prakriti-nith
Copy link
Contributor

This pull request is for the bug fix in the documentation.
If the user runs $ docker logs -f critiquebrainz_web_test_1, following error occurs:
Error: No such container: critiquebrainz_web_test_1

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@Prakriti-nith Prakriti-nith changed the title Change container name in Tesing Change container name in Testing Feb 12, 2018
@ferbncode
Copy link
Member

@brainzbot add to whitelist

@paramsingh
Copy link
Collaborator

@Prakriti-nith instead of running tests in the background and then running docker logs, I think just telling people to run docker-compose -f docker/docker-compose.test.yml up --build would be better

@paramsingh paramsingh merged commit b79e252 into metabrainz:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants