LB-148: Add integration tests to api_compat feature #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be a lot of work to move relevant tests to their PRs? Perhaps we could merge #353 with just the one test, followed by adding more tests in this PR (or other bugfix PRs) |
|
Yes, that can be done. Tests in the first 2 commits will pass with current state of API. Should i delete other commits from this PR to make it valid? |
|
Let's try to get #353 merged first and then you can rebase this. |
paramsingh
reviewed
Feb 16, 2018
This commit includes the test to check if the token generated is valid or not and returns appropriate error codes.
Tests for session establishing using valid token and invalid token are written in this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes some tests for api_compat feature
Problem
Currently there are no tests for last.fm compatible API. Which makes it hard to debug and figure out
if it's working or not.
Solution
Add tests.