Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Nikola: remove input pytest-mock #34890

Merged
merged 1 commit into from Feb 12, 2018
Merged

pythonPackages.Nikola: remove input pytest-mock #34890

merged 1 commit into from Feb 12, 2018

Conversation

jluttine
Copy link
Member

Motivation for this change

Remove an unnecessary check input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 12, 2018 12:25
@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.Nikola

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

nikola/shortcodes.py                                220     17    92%   53-58, 101-102, 152, 190, 205, 250-251, 370, 386-390
nikola/state.py                                      41      6    85%   72-75, 79-80
nikola/utils.py                                    1094    407    63%   52-53, 120-123, 145, 165, 172-176, 201, 203, 208, 213-215, 221-223, 233-235, 241, 251, 257-260, 306-307, 311, 347-353, 373, 381-384, 403, 409, 418, 426-430, 434-435, 442, 453, 457-460, 464-467, 494-495, 525-533, 537, 541, 576, 582, 589, 606, 619, 623, 651-656, 669-676, 700-701, 705, 732-733, 740-741, 774, 791-802, 810, 837, 839, 869, 884-885, 901-916, 930-931, 940, 964, 971-972, 977, 991, 1096, 1156, 1175, 1216-1219, 1257-1259, 1265-1269, 1281, 1290-1292, 1299, 1366, 1372, 1375-1376, 1389, 1400, 1403, 1455, 1468-1509, 1514-1525, 1530-1546, 1553-1554, 1557-1561, 1576-1607, 1610, 1614-1630, 1634, 1648-1651, 1670, 1672, 1689, 1696-1716, 1722-1732, 1737, 1742-1746, 1767-1790, 1795-1806, 1814-1832, 1867-1885, 1897-1904, 1909-1928, 1935-1944, 1954, 1963-1965, 1994, 1998-2003, 2017-2019, 2031, 2068, 2071
nikola/winutils.py                                   52     52     0%   27-124
-------------------------------------------------------------------------------
TOTAL                                             11329   4494    60%


=================== 185 passed, 1 skipped in 115.69 seconds ====================
/nix/store/n363zrpd93jb0lqzxrwpllvbw9vs2lyh-python3.6-Nikola-7.8.11

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

nikola/shortcodes.py                                220     17    92%   53-58, 101-102, 152, 190, 205, 250-251, 370, 386-390
nikola/state.py                                      41      6    85%   72-75, 79-80
nikola/utils.py                                    1094    407    63%   52-53, 120-123, 145, 165, 172-176, 201, 203, 208, 213-215, 221-223, 233-235, 241, 251, 257-260, 306-307, 311, 347-353, 373, 381-384, 403, 409, 418, 426-430, 434-435, 442, 453, 457-460, 464-467, 494-495, 525-533, 537, 541, 576, 582, 589, 606, 619, 623, 651-656, 669-676, 700-701, 705, 732-733, 740-741, 774, 791-802, 810, 837, 839, 869, 884-885, 901-916, 930-931, 940, 964, 971-972, 977, 991, 1096, 1156, 1175, 1216-1219, 1257-1259, 1265-1269, 1281, 1290-1292, 1299, 1366, 1372, 1375-1376, 1389, 1400, 1403, 1455, 1468-1509, 1514-1525, 1530-1546, 1553-1554, 1557-1561, 1576-1607, 1610, 1614-1630, 1634, 1648-1651, 1670, 1672, 1689, 1696-1716, 1722-1732, 1737, 1742-1746, 1767-1790, 1795-1806, 1814-1832, 1867-1885, 1897-1904, 1909-1928, 1935-1944, 1954, 1963-1965, 1994, 1998-2003, 2017-2019, 2031, 2068, 2071
nikola/winutils.py                                   52     52     0%   27-124
-------------------------------------------------------------------------------
TOTAL                                             11329   4494    60%


=================== 185 passed, 1 skipped in 469.00 seconds ====================
/nix/store/yykap0ip60n7df9jl2md0q6xzm1qaxvj-python3.6-Nikola-7.8.11

@Mic92 Mic92 merged commit daae04d into NixOS:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @dotlambda @GrahamcOfBorg @Mic92