Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: docker: 2.7.0 -> 3.0.0" #35086

Merged
merged 1 commit into from Feb 18, 2018
Merged

Revert "python: docker: 2.7.0 -> 3.0.0" #35086

merged 1 commit into from Feb 18, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 17, 2018 •
edited

Motivation for this change

pythonPackages.docker isn't compatible with docker-compose 1.18 and
causes severe breackage when running docker-compose up --build.

See docker/compose#5685 for further reference.

This reverts commit 2a8a058.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
Revert "python: docker: 2.7.0 -> 3.0.0"
554e91e 
`pythonPackages.docker` isn't compatible with `docker-compose` 1.18 and
causes severe breackage when running `docker-compose up --build`.

See docker/compose#5685 for further reference.

This reverts commit 2a8a058.
@Ma27 Ma27 requested a review from FRidh as a code owner February 17, 2018 23:46
@Ma27
Copy link
Member Author

Ma27 commented Feb 18, 2018

nox-review fails because of pythonPackages.smart_open which is broken on master as well.

@FRidh FRidh merged commit e4e1f04 into NixOS:master Feb 18, 2018
@Ma27 Ma27 deleted the downgrade-python-docker-to-2.7 branch February 18, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @FRidh @GrahamcOfBorg