Some QuantStack libraries #35096
Some QuantStack libraries #35096
Conversation
|
|
||
| let | ||
| pname = "gast"; | ||
| version = "0.2.0"; |
There was a problem hiding this comment.
these two should go into buildPythonPackage
| pname = "gast"; | ||
| version = "0.2.0"; | ||
| in buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
| let version = "4.0.0" | ||
| ; in | ||
| stdenv.mkDerivation { | ||
| version = version; |
There was a problem hiding this comment.
version is not an attribute of stdenv.mkDerivation
| version = version; | ||
| name = "xsimd-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
maybe use fetchFromGitHub? At least insert ${version}
| stdenv.mkDerivation rec { | ||
| version = "0.15.4"; | ||
| name = "xtensor-${version}"; | ||
|
|
| stdenv.mkDerivation rec { | ||
| version = "0.4.0"; | ||
| name = "xtl-${version}"; | ||
|
|
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/serge-sans-paille/gast/archive/master.zip"; |
There was a problem hiding this comment.
fetching from master is a bad idea, not reproducible
There was a problem hiding this comment.
Yeah, but it doesn't have any release or tag. Should I go for a commit?
There was a problem hiding this comment.
Yep. Do try to find the commit corresponding to the version.
|
|
||
| let | ||
| pname = "pythran"; | ||
| version = "0.8.4.post0"; |
| pname = "pythran"; | ||
| version = "0.8.4.post0"; | ||
| in buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
pkgs/top-level/python-packages.nix
Outdated
| @@ -21869,6 +21874,8 @@ EOF | |||
| pysigset = callPackage ../development/python-modules/pysigset { }; | |||
|
|
|||
| us = callPackage ../development/python-modules/us { }; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
please don't include any whitespace changes
|
I have to think about what we should do with networkx considering we typically only permit a single version of a package. |
|
Thanks for detailed review. Much needed: it's my first try :) |
|
Should be ok now, except for networkx. Let me know if I should change something |
|
Networkx 2 is already in the staging branch. We should wait until that is merged. |
|
Networkx v2 is in master. Please rebase and remove your expression for v2. |
|
What is the status of this pull request? |
|
Nothing happening so closing. |
Motivation for this change
Missing libraries from the QuantStack ecosystem
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)