discover: init at 5.15.3 #34756
discover: init at 5.15.3 #34756
Conversation
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
I think it is not useful, because everything you install will not be runable. So, I would not add the discover package. |
|
And for those wondering what "discover" is supposed to do anyway: https://userbase.kde.org/Discover After reading that I would agree it doesn't seem to be a good idea to inlcude. Does existing software cleanly deal with its omission (no do-nothing buttons or borked context menu entries...)? |
|
I agree, I don't think this adds any value for our users.
AFAIK, everything works correctly without it. And if not, that's upstream's problem for not checking dependencies 😉 |
|
Discover supposedly supports flatpak (and snap?) as a mechanism to install software which could be compatible with NixOS albeit far from the preferred option for getting software installed. |
|
I think you are right, but are they only ship flatpaks/snaps with Discover? |
Discover can also be used to install/upgrade distribution packages which doesn't apply in to our situation. |
peterhoeg
force-pushed
the
p/discover
branch
from
42a4f1f
to
8e13118
Compare
|
So I haven't given up completely on this yet. Discover can be used to handle things obtained through "Get New Hot Stuff" such as icons, wallpapers, plasma widgets and so on. When (if?) we get flatpak support at some point, discover can be used for that too. And should anyone decide to write a nix-env backend that would be an option as well. In my opinion, the "Get Hot New Stuff" use-case is sufficiently strong to include discover. Note: The appstream bits are included in #35308. |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
peterhoeg
force-pushed
the
p/discover
branch
from
8e13118
to
b0b04c1
Compare
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
peterhoeg
force-pushed
the
p/discover
branch
from
b0b04c1
to
a2bf68a
Compare
|
We will have packagekit-nix eventually. And flatpak support is only missing tests in order to be merged. |
|
The reasons for not merging discover are disappearing fast! Thanks for your work on flatpak - looking forward to that. |
peterhoeg
force-pushed
the
p/discover
branch
2 times, most recently
from
76af08f
to
876404f
Compare
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: appstream-qt, discover Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: appstream-qt, discover Partial log (click to expand)
|
|
We're getting closer although the flatpak bits aren't quite working yet. |
|
Any progress? |
|
Not quite. It's currently blowing up complaining about packagekit but I haven't had the time to look at it. |
|
This PR alone allows installing application and plasma addons (not applications) but requires #60146 in order to not complain like crazy. While flatpak support is compiled in, it doesn't work yet but I don't think that's a show stopper for merging as is. |
|
Using somewhat different tree[1] I can run this and successfully installed a flatpak app "kstars" and it runs successfully! [1]
Anyway! This seems good--it's a bit unpolished UI experience that seems generally not always handling gracefully some of the details of our environment. Anyway I think that's arguably upstream issue and our portion of it can be iterated on IMO. Didn't have the courage to see what happens if I install things like cursors or themes O:). |
|
Can you share more details on getting flatpak running? I have it enabled as well as the kde portal, but discover doesn't show any flatpaks. |
Motivation for this change
Is this worth merging considering discover doesn't actually do anything on NixOS?
Cc: @bkchr @adisbladis @ttuegel
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)