Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple users with hashedPassword is broken in mosquitto #34753

Merged
merged 1 commit into from Feb 10, 2018
Merged

Multiple users with hashedPassword is broken in mosquitto #34753

merged 1 commit into from Feb 10, 2018

Conversation

noqqe
Copy link
Contributor

@noqqe noqqe commented Feb 8, 2018

If you have more than 1 User with hasedPassword Option set it generates

rm -f /var/lib/mosquitto/passwd
touch /var/lib/mosquitto/passwd
echo 'user1:$6$xxx' > /var/lib/mosquitto/passwd
echo 'user2:$6$xxx' > /var/lib/mosquitto/passwd

Which ends up in only having 1 user.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

If you have more than 1 User with hasedPassword Option set it generates 

```
rm -f /var/lib/mosquitto/passwd
touch /var/lib/mosquitto/passwd
echo 'user1:$6$xxx' > /var/lib/mosquitto/passwd
echo 'user2:$6$xxx' > /var/lib/mosquitto/passwd
```

Which ends up in only having 1 user.
@andir
Copy link
Member

andir commented Feb 9, 2018

Thanks! Looks good to me. 👍

Do you mind opening another PR for stable? It suffers from the same issue.

@noqqe
Copy link
Contributor Author

noqqe commented Feb 9, 2018

@andir Yep I can. Just to doublecheck: on branch "staging-17.09" ?

@andir
Copy link
Member

andir commented Feb 9, 2018 via email

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@noqqe no release-17.03 instead of staging-

@Mic92 Mic92 merged commit 5be14cc into NixOS:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants