New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.mal: init at 2018-03-01 #36762
Conversation
@@ -0,0 +1,21 @@ | |||
{ stdenv, buildPythonPackage, fetchPypi, isPy27, isPy34, isPy35, isPy36 }: | |||
|
|||
assert (isPy27 || isPy34 || isPy35 || isPy36); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed and replaced with a disabled = ...;
argument passed to buildPython*
assert (isPy27 || isPy34 || isPy35 || isPy36); | ||
|
||
buildPythonPackage rec { | ||
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name
attribute is added by buildPython*
and should therefore be removed.
|
||
# tests currently fail on Python 3.6, try adding isPy36 when the next version | ||
# after 0.3.2 is released | ||
assert (isPy34 || isPy35); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
assert (isPy34 || isPy35); | ||
|
||
buildPythonPackage rec { | ||
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name
attribute is added by buildPython*
and should therefore be removed.
4fcb4a4
to
5a144af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mal
is not a library and should therefore use buildPythonApplication
and be moved out of pythonPackages
.
The package seems to not work anymore so we don't need it. |
@taktoa can you please confirm if this package is no longer functional and close if so? |
Motivation for this change
Adds the mal Python package.
Things done
nix-shell -p nox --run "nox-review wip"
./result/bin/
)