Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 0.91 -> 1.0 #36761

Closed
wants to merge 3 commits into from
Closed

renderdoc: 0.91 -> 1.0 #36761

wants to merge 3 commits into from

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Mar 10, 2018

Motivation for this change

Official 1.0 release 🎉
Thanks to changes in nix 2.0 and renderdoc upstream, the expression is also slightly cleaner now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build renderdoc

@7c6f434c
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: renderdoc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: renderdoc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: renderdoc

Partial log (click to expand)

[ 72%] Built target rdoc_gl
[ 72%] Building CXX object renderdoc/driver/vulkan/CMakeFiles/rdoc_vulkan.dir/wrappers/vk_shader_funcs.cpp.o
[ 72%] Building CXX object renderdoc/driver/vulkan/CMakeFiles/rdoc_vulkan.dir/wrappers/vk_sync_funcs.cpp.o
[ 73%] Building CXX object renderdoc/driver/vulkan/CMakeFiles/rdoc_vulkan.dir/wrappers/vk_wsi_funcs.cpp.o
[ 73%] Building CXX object renderdoc/driver/vulkan/CMakeFiles/rdoc_vulkan.dir/vk_posix.cpp.o
[ 73%] Building CXX object renderdoc/driver/vulkan/CMakeFiles/rdoc_vulkan.dir/vk_linux.cpp.o
[ 73%] Built target rdoc_vulkan
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/8jsyqlyiaag9661hqjsai1bw25hlr492-renderdoc-1.0.drv’ failed with exit code 2
error: build of ‘/nix/store/8jsyqlyiaag9661hqjsai1bw25hlr492-renderdoc-1.0.drv’ failed

@7c6f434c
Copy link
Member

@jansol looks like it fails

@jansol
Copy link
Contributor Author

jansol commented Mar 26, 2018

Weird. Debugging it would require patching the CMakeLists.txt to not send output of the custom_swig build step to /dev/null. Unfortunately I won't have access to a machine where I could reasonably debug this in a long time.

@Ralith Ralith mentioned this pull request Jul 8, 2018
Merged
9 tasks
@jansol
Copy link
Contributor Author

jansol commented Jul 8, 2018

Closing in favor of #43159

@jansol jansol closed this Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jansol @7c6f434c @GrahamcOfBorg @xeji