PICARD-1220: Add keyboard shortcut to delete scripts. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
previous discussion can be found on #874 |
samj1912
requested changes
Mar 10, 2018
picard/ui/options/scripting.py
Outdated
| @@ -232,6 +232,14 @@ def __init__(self, parent=None): | |||
| self.last_selected_script_pos = 0 | |||
| self.ui.splitter.setStretchFactor(0, 1) | |||
| self.ui.splitter.setStretchFactor(1, 2) | |||
| self.shortcut = QtWidgets.QShortcut(self.ui.script_list) | |||
| self.shortcut.setKey(QtGui.QKeySequence.Delete) | |||
| self.shortcut.activated.connect(self.script_remove_processor) | |||
There was a problem hiding this comment.
Rename this to self.delete_selected_script
samj1912
reviewed
Mar 10, 2018
picard/ui/options/scripting.py
Outdated
| @@ -232,6 +232,14 @@ def __init__(self, parent=None): | |||
| self.last_selected_script_pos = 0 | |||
| self.ui.splitter.setStretchFactor(0, 1) | |||
| self.ui.splitter.setStretchFactor(1, 2) | |||
| self.delete_selected_script = QtWidgets.QShortcut(self.ui.script_list) | |||
| self.delete_selected_script.setKey(QtGui.QKeySequence.Delete) | |||
| self.delete_selected_script.activated.connect(self.script_remove_processor) | |||
There was a problem hiding this comment.
@vishichoudhary I meant the connected function. The shortcut variable itself could be self.delete_shortcut.
There was a problem hiding this comment.
Shouldn't say this but. naming the variables to seem most difficult task for me. :-( 😅
Add keyboard shortcut to delete scripts Add keyboard shortcut to delete scripts
zas
approved these changes
Mar 10, 2018
samj1912
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
In options > Scripting. On pressing delete key, the script will be removed.
Action