Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bip: Fix build #36764

Merged
merged 1 commit into from Mar 12, 2018
Merged

bip: Fix build #36764

merged 1 commit into from Mar 12, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 10, 2018 •
edited

Motivation for this change

bip build failed due to a compiler warning.
/cc ZHF #36453
Should be backported to 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Mar 10, 2018

@GrahamcOfBorg build bip

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘bip-0.8.9’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/irc/bip/default.nix:31 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9
shrinking /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9/bin/bipmkpw
shrinking /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9/bin/bip
gzipping man pages under /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9/bin
patching script interpreter paths in /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9
checking for references to /build in /nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9...
/nix/store/2lphabhb36f4fk2x9nxr9niv8srsfq3s-bip-0.8.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9
shrinking /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9/bin/bip
shrinking /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9/bin/bipmkpw
gzipping man pages under /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9/bin
patching script interpreter paths in /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9
checking for references to /build in /nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9...
/nix/store/n5adckmnq8y3m407m007s1isp1adaq4x-bip-0.8.9

@vcunat vcunat self-assigned this Mar 12, 2018
vcunat added a commit that referenced this pull request Mar 12, 2018
@vcunat
Merge #36764: bip: fixup build with gcc7
ec46986 
(cherry picked from commit 8eca635)
@LnL7 LnL7 merged commit 95e88ad into NixOS:master Mar 12, 2018
vcunat added a commit that referenced this pull request Mar 12, 2018
@vcunat
Merge #36764: bip: fixup build with gcc7
8eca635
@timokau timokau deleted the bip-fix branch March 12, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timokau @grahamc @GrahamcOfBorg @vcunat @LnL7