PICARD-1220: Add keyboard shortcut to delete scripts in options page. #874
Conversation
vishichoudhary
changed the title
|
This is a destructive command. You'd probably want some sort of confirmation. |
|
@sambhav there exist confirmation, it simply call remove method. Which in turn shows a confirmation dialog. |
| self.shortcut.setKey(QtGui.QKeySequence.Delete) | ||
| self.shortcut.activated.connect(self.processor_delete_item) | ||
|
|
||
| def processor_delete_item(self): |
There was a problem hiding this comment.
Please conform to python method naming used in the rest of the project code.
There was a problem hiding this comment.
@sambhav script_delete_processor is ok?
There was a problem hiding this comment.
delete_selected_script should do.
|
@VishalChoudhary please put more efforts into the quality of code you produce. It gets very tiresome for both you and the reviewers to point such trivial mistakes again and again. Please make sure that you are following the contribution guidelines WRT naming, comments, commit messages and PR descriptions. Since this is a feature addition, I'd expect some sort of ticket to reflect the same in the changelog. |
|
@sambhav ok I will open a ticket. apologies for the inconvenience. |
vishichoudhary
changed the title
Summary
Problem
JIRA PICARD-1220
Solution
In options > Scripting. On pressing delete key, the script will be removed.