nixos/hans: init #36734
Merged
nixos/hans: init #36734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Mar 10, 2018
| uid = config.ids.uids.hans; | ||
| description = "Hans daemon user"; | ||
| }; | ||
| users.extraGroups.hans.gid = config.ids.gids.hans; |
There was a problem hiding this comment.
Fixed uid/gids should not be required since hans has no persistent files.
|
@Mic92 Fixed, thank you! |
Mic92
reviewed
Mar 28, 2018
| EOF | ||
| chmod 700 /run/iodined/script | ||
| ''; | ||
| script = "/run/iodined/script"; |
There was a problem hiding this comment.
You can put the same script here as a string, you wrote into /run/iodined/script without any need for shebangs.
Mic92
reviewed
Mar 28, 2018
| EOF | ||
| chmod 700 /run/iodine/${name}-script | ||
| ''; | ||
| script = "/run/iodine/${name}-script"; |
Mic92
reviewed
Mar 28, 2018
| EOF | ||
| chmod 700 /run/hans/script | ||
| ''; | ||
| script = "/run/hans/script"; |
Mic92
reviewed
Mar 28, 2018
| #!/bin/sh | ||
| ${pkgs.hans}/bin/hans -f -u ${hansUser} ${cfg.extraConfig} -c ${cfg.server} ${optionalString (cfg.passwordFile != "") "-p $(cat \"${cfg.passwordFile}\")"} | ||
| EOF | ||
| chmod 700 /run/hans/${name}-script |
|
@Mic92 Thanks! |
fpletz
reviewed
Mar 28, 2018
| type = types.bool; | ||
| default = false; | ||
| description = "Respond to ordinary pings"; | ||
| }; |
There was a problem hiding this comment.
I don't think this option belongs in this module. We also have networking.firewall.allowPing.
There was a problem hiding this comment.
@fpletz Renamed. This is pure hans option https://github.com/albertzak/hanstunnel#cant-connect
|
@matthewbauer Thank you! |
ghost
deleted the
ghost
mentioned this pull request
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add module for Hans IP over ICMP tunnel. Mostly copypaste of iodine module.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)