Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gplaycli: 0.1.2 -> 3.21 #36776

Merged
merged 1 commit into from Mar 12, 2018
Merged

pythonPackages.gplaycli: 0.1.2 -> 3.21 #36776

merged 1 commit into from Mar 12, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 10, 2018 •
edited

Motivation for this change

Fix the broken package: https://hydra.nixos.org/build/70687256/log

The newer version requires two new dependencies that have been added as
well:

  • gpapi (Unofficial Python API for Google Play) at version 0.4.2
  • pyaxmlparser (Parser for Android's XML handler) at version 0.3.7
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner March 10, 2018 23:12
@Ma27
Copy link
Member Author

Ma27 commented Mar 10, 2018

see #36453

@Ma27
pythonPackages.gplaycli: 0.1.2 -> 3.21
4feaaa7 
Fix the broken package: https://hydra.nixos.org/build/70687256/log

The newer version requires two new dependencies that have been added as
well:

- gpapi (Unofficial Python API for Google Play) at version 0.4.2
- pyaxmlparser (Parser for Android's XML handler) at version 0.3.7

See ticket NixOS#36453
See https://hydra.nixos.org/build/70687256/log
@fpletz
Copy link
Member

fpletz commented Mar 12, 2018

@GrahamcOfBorg build pythonPackages.gplaycli

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.gplaycli

No log is available.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.gplaycli

No log is available.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.gplaycli

No log is available.

@fpletz
Copy link
Member

fpletz commented Mar 12, 2018

@GrahamcOfBorg build python3Packages.gplaycli

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.gplaycli

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'credentials.conf'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/fqx3wqh565gbvk08ddrkr2c0i6nlp3gq-python3.6-gplaycli-3.21

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.gplaycli

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'credentials.conf'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/hp5f5l1ks36nvv039qlc8jhj1x6hc1hk-python3.6-gplaycli-3.21

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.gplaycli

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'credentials.conf'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/0s3i0pm06kqnxfg0xxz7ap8c90ndsiia-python3.6-gplaycli-3.21

@fpletz fpletz merged commit a1af032 into NixOS:master Mar 12, 2018
@Ma27 Ma27 deleted the fix-gplaycli branch March 13, 2018 07:14
@Ma27
Copy link
Member Author

Ma27 commented Mar 13, 2018

@fpletz shouldn't we backport this to release-18.03? This package caused a build failure on the 18.03 job on the NixOS Hydra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @fpletz @GrahamcOfBorg