Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vale: init at 0.10.1 #36775

Merged
merged 2 commits into from Mar 19, 2018
Merged

vale: init at 0.10.1 #36775

merged 2 commits into from Mar 19, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 10, 2018

Motivation for this change

Add Vale package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 11, 2018

Are you willing to add yourself as the maintainer of this package?

@grahamc
Copy link
Member

grahamc commented Mar 11, 2018

@GrahamcOfBorg build vale

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/gobwas/glob/bench.sh: interpreter directive changed from " /bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/jdkato/regexp/export.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-vale-0.10.1.drv-0 in /nix/store/x2zc57cyy6axwz83rfsja1272w95sl7j-vale-0.10.1...
/nix/store/90c20shhbyii6r5wm94gnkzwzn6dda42-vale-0.10.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vale

Partial log (click to expand)

patching script interpreter paths in /nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/jdkato/regexp/export.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/77qr4paailczvb2jl2s9grgpqz8fxp8p-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/gobwas/glob/bench.sh: interpreter directive changed from " /bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/5278yjpvaynd2rsf175s3dxzx9zmrgs8-vale-0.10.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vale

Partial log (click to expand)

/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/gobwas/glob/bench.sh: interpreter directive changed from " /bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/github.com/jdkato/regexp/export.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1/share/go/src/github.com/ValeLint/vale/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/h1zky3ammj76ksy7qzpvw17fwhz3ff4s-vale-0.10.1...
/nix/store/3plgfkvvfvvkfd84rjrzjics25l7770b-vale-0.10.1-bin

@marsam
Copy link
Contributor Author

marsam commented Mar 12, 2018

@ryantm sure, do I add myself to maintainer-list.nix?

@ryantm
Copy link
Member

ryantm commented Mar 12, 2018

Yes, please!

@marsam
Copy link
Contributor Author

marsam commented Mar 12, 2018

done :)

@matthewbauer matthewbauer merged commit 50fcb34 into NixOS:master Mar 19, 2018
@marsam marsam deleted the feature/add-valelint branch June 9, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @ryantm @grahamc @GrahamcOfBorg @matthewbauer