Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: add option for cgroup accounting #36772

Merged
merged 1 commit into from Mar 27, 2018
Merged

nixos/systemd: add option for cgroup accounting #36772

merged 1 commit into from Mar 27, 2018

Conversation

davidak
Copy link
Member

@davidak davidak commented Mar 10, 2018 •
edited

Motivation for this change

Monitoring with netdata #29095
debugging the system

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bgamari
Copy link
Contributor

bgamari commented Mar 11, 2018

Are there cases here one might want to enable/disable these cgroup namespaces independently?

@davidak
Copy link
Member Author

davidak commented Mar 12, 2018

@bgamari i can't think of any reason, but there might be special cases. then one still can disable this option and use systemd.extraConfig.

garbas
garbas requested changes Mar 17, 2018
View reviewed changes
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the option. This is something everybody using nixos for desktop should enable. but for servers it should be false since it comes with a bit of performance hit. For this reason I would like to change the default value to false.

@davidak
Copy link
Member Author

davidak commented Mar 25, 2018

@garbas thanks for the feedback!

i changed default to false.

so should this get enabled when a DE is enabled?

@garbas
Copy link
Member

garbas commented Mar 27, 2018

I think having it false by default is ok, we can have a different discussion about it if we want to enable this or not and when.

@garbas garbas merged commit 4167600 into NixOS:master Mar 27, 2018
@davidak davidak deleted the cgroup-accounting branch March 27, 2018 22:35
@davidak davidak mentioned this pull request Aug 20, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidak @bgamari @garbas @GrahamcOfBorg