scriptcommunicator: init at 05.10 #36747
Conversation
bignaux
force-pushed
the
scriptcomm
branch
2 times, most recently
from
d30d25f
to
245e054
Compare
bignaux
changed the title
|
@GrahamcOfBorg : build scriptcommunicator |
| sourceRoot = "source/ScriptCommunicator"; | ||
|
|
||
| buildPhase = '' | ||
| cd DeleteFolder/DeleteFolder |
There was a problem hiding this comment.
Do you have to cd into the directories for qmake to work?
If you have to, I think you could use qmake -r DeleteFolder.pro ScriptEditor.pro ScriptCommunicator.pro
There was a problem hiding this comment.
No way, i don't success to do that.
There was a problem hiding this comment.
pushd and popd might be a bit nicer to use here
There was a problem hiding this comment.
i don't have time to make a perfect recipe for this bugging tool. I improve derivation on new release, time to time. Better is the enemy of good.
There was a problem hiding this comment.
@bignaux no worries. Just trying to be helpful and promote consistent coding style within nixpkgs.
| cp ScriptCommunicator $out/share/scriptcommunicator/ | ||
| cp documentation/Manual_ScriptCommunicator.pdf $out/share/scriptcommunicator/ | ||
|
|
||
| makeWrapper $out/share/scriptcommunicator/ScriptCommunicator $out/bin/scriptcommunicator \ |
There was a problem hiding this comment.
Why not copy directly to $out/bin and wrap with wrapProgram $out/bin/Scriptcommunicator --[args]?
|
|
||
| # Need to fix this - i don't populate with it for now. | ||
| #cp aardvarkI2cSpi/aardvark.so cheetahSpi/cheetah.so $out/lib/ | ||
| cp -a ScriptEditor/apiFiles exampleScripts images templates test $out/share/scriptcommunicator |
There was a problem hiding this comment.
Do we need test? Do you know what they do or how to run them?
There was a problem hiding this comment.
anyway if we would test really , we need special hardware, plus i think cheetahspi is closed source and globally, this scriptcommunicator is not written by a developer using linux so things are a bit ugly on the build system. If people need it, he has to write some PR. i find this tool very interesting in the feature (qt script, qt ui and so) and i think 99% of possible user on nixos would use it for simple serial that i test. So no really harmful.
There was a problem hiding this comment.
Yeah, I noticed - it's rough...
Sure, I'd be happy if you can confirm that the main functionality works.
I'd change the commend to something like # Cheetah and its wrapper are proprietary libraries and need special hardware
There was a problem hiding this comment.
fixed according to author.
|
Builds and runs for me :) |
|
Please merge it like it is for the moment, i'll improve later with help of the author. |
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
Motivation for this change
new
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)