Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcgiwrap: fix build with gcc7 #36766

Closed
wants to merge 1 commit into from
Closed

fcgiwrap: fix build with gcc7 #36766

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 10, 2018

Motivation for this change

Fix build with gcc7.

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 10, 2018

@GrahamcOfBorg build fcgiwrap

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

moving /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/man to /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0
shrinking /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin
patching script interpreter paths in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0
checking for references to /build in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0...
moving /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin/* to /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/bin
/nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

moving /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/man to /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0
shrinking /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin
patching script interpreter paths in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0
checking for references to /build in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0...
moving /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin/* to /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/bin
/nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0

@ryantm
Copy link
Member

ryantm commented Mar 10, 2018

related? #36765

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: fcgiwrap

No log is available.

@pbogdan
Copy link
Member Author

pbogdan commented Mar 11, 2018

Oh, didn't see #36765 when submitting. Closing. Thanks!

@pbogdan pbogdan closed this Mar 11, 2018
@timokau
Copy link
Member

timokau commented Mar 11, 2018

To be honest I prefer your approach. Patching the one occurence of the error seems better than ignoring it alltogether. And when upstream decides to fix it on the next release, applying the patch will probably fail and the patch will be removed (whereas the -Wno-error will probably be kept indefinately because nobody has reason to remove it).

@pbogdan
Copy link
Member Author

pbogdan commented Mar 11, 2018

Makes sense, let's re-open this then :-).

@pbogdan pbogdan reopened this Mar 11, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fcgiwrap

Partial log (click to expand)

moving /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/man to /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0
shrinking /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin 
patching script interpreter paths in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0
checking for references to /tmp/nix-build-fcgiwrap-1.1.0.drv-0 in /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0...
moving /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/sbin/* to /nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0/bin
/nix/store/9488fzfs8cljyh3vgfdfbpk6bv8npjvj-fcgiwrap-1.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fcgiwrap

Partial log (click to expand)

moving /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/man to /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0
shrinking /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin
patching script interpreter paths in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0
checking for references to /build in /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0...
moving /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/sbin/* to /nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0/bin
/nix/store/ijl9gjdbidjarp737z2f86xfxxrf0akn-fcgiwrap-1.1.0

@timokau timokau mentioned this pull request Mar 11, 2018
Closed
8 tasks
@vcunat
Copy link
Member

vcunat commented Mar 12, 2018

I merged #36807 already.

@vcunat vcunat closed this Mar 12, 2018
@pbogdan pbogdan deleted the fcgiwrap-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pbogdan @ryantm @GrahamcOfBorg @timokau @vcunat