a52dec: add -fPIC to CFLAGS #35895
Closed
a52dec: add -fPIC to CFLAGS #35895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without -fPIC gst-plugins.ugly fails to compile. The problem is that a52dec builds a static library. This library is then used to create a gstreamer-plugin .so. The linking fails if a52dec is compiled without -fPIC. This problem manifests itself only when hardening is disabled. As when hardening is enabled -fPIC is added automatically.
|
👎 this is handled by hardening, please override hardeningDisable if you are setting it elsewhere, this does not belong in upstream nixpkgs. Closing if there is no further reason, other than having hardening disabled manually. |
|
Also, |
|
@globin But shouldn't packages be buildable even when hardening is disabled? I mean the reliance on the fact that hardening adds -fPIC seems to be a bit fragile. Isn't it better to specify this explicitly? BTW, I would say that it is a bad practice to link a static library into a dynamic one. But this is a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without -fPIC gst-plugins.ugly fails to compile. The problem
is that a52dec builds a static library. This library is then used
to create a gstreamer-plugin .so. The linking fails if a52dec is
compiled without -fPIC.
This problem manifests itself only when hardening is disabled.
As when hardening is enabled -fPIC is added automatically.
Things done
Tested on 17.09. I haven't built it on master.