Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: fix darwin build #36699

Merged
merged 1 commit into from Mar 11, 2018
Merged

mpv: fix darwin build #36699

merged 1 commit into from Mar 11, 2018

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 9, 2018 •
edited

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)
The optional video acceleration api (vaapi) is not supported on darwin. Disabling it fixes the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp
mpv: fix darwin build
38c589b 
The optional video acceleration api (vaapi) is not supported on darwin.
@LnL7
Copy link
Member

LnL7 commented Mar 11, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: mpv

No log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  7 1720k    7  135k    0     0   135k      0  0:00:12  0:00:01  0:00:11  134k
100 1720k  100 1720k    0     0  1720k      0  0:00:01  0:00:01 --:--:--  920k

fetching path ‘/nix/store/2yr38b81j9310hibd25w7zb00miqwkc3-mpv-0.27.0’...

*** Downloading ‘https://cache.nixos.org/nar/1v2n6j73v2302qawv8m2hfdbl7rji2fkfj3rk3vjc17r01cbkqx7.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/2yr38b81j9310hibd25w7zb00miqwkc3-mpv-0.27.0’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 19  986k   19  196k    0     0   196k      0  0:00:05 --:--:--  0:00:05  211k
100  986k  100  986k    0     0   986k      0  0:00:01  0:00:01 --:--:--  616k

/nix/store/2yr38b81j9310hibd25w7zb00miqwkc3-mpv-0.27.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

copying path '/nix/store/8yfr2g6vsgd7snr7l4dqn7n8vdka6hxx-qtlocation-5.10.1' from 'https://cache.nixos.org'...
copying path '/nix/store/5gpc1ilpnhn2mbbzl5xknwg3vjns28df-qtmultimedia-5.10.1' from 'https://cache.nixos.org'...
copying path '/nix/store/nffawk9rmpykgfl4bvp7caqd0jjlcksn-qtmultimedia-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/wrmrkzfi4cp7kl451074cfv797m5mknm-qtsensors-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/j1gnvpzwybd3hdqlqsa96x6i55dgb1qx-qtlocation-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/m9xcfi4sa7hvjbyaiqwcw55kg223wlsz-qtwebkit-5.9.1' from 'https://cache.nixos.org'...
copying path '/nix/store/01aadrdw75mhn0fk01wb18jv5wj6q7px-phantomjs-2.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/0pqjnrwrhyiallskahv1srqx05yw0wsi-youtube-dl-2018.03.03' from 'https://cache.nixos.org'...
copying path '/nix/store/lzwfkkvkisa3bfcs78hs7ziaxrxxq2cs-mpv-0.27.0' from 'https://cache.nixos.org'...
/nix/store/lzwfkkvkisa3bfcs78hs7ziaxrxxq2cs-mpv-0.27.0

@LnL7 LnL7 merged commit 370e01a into NixOS:master Mar 11, 2018
@LnL7
Copy link
Member

LnL7 commented Mar 11, 2018

@grahamc The darwin evaluation should have succeeded.

@grahamc
Copy link
Member

grahamc commented Mar 11, 2018 via email

@knedlsepp knedlsepp deleted the fix-mpv-on-darwin branch March 11, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @LnL7 @GrahamcOfBorg @grahamc