Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dislocker: 0.6.1 -> 0.7.1 #36694

Merged
merged 1 commit into from Mar 12, 2018
Merged

dislocker: 0.6.1 -> 0.7.1 #36694

merged 1 commit into from Mar 12, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 9, 2018

Motivation for this change

0.6.1 didn't build with gcc7, 0.7.1 does

/cc ZHF #36453
/cc @elitak

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@elitak
Copy link
Contributor

elitak commented Mar 9, 2018

git rm pkgs/tools/filesystems/dislocker/cmake_dirfix.patch as well and this will be good to go.

@xeji
Copy link
Contributor Author

xeji commented Mar 9, 2018

thank you - removed obsolete patch and squashed into one commit

@xeji
Copy link
Contributor Author

xeji commented Mar 10, 2018

@GrahamcOfBorg build dislocker

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/bin/dislocker-metadata
shrinking /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/bin/dislocker-file
shrinking /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/bin/dislocker-fuse
shrinking /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/lib/libdislocker.so.0.7.1
gzipping man pages under /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/lib  /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1/bin
patching script interpreter paths in /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1
checking for references to /build in /nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1...
/nix/store/vra26210jszmbqjk3gsjhxcma9kaz5iz-dislocker-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/bin/dislocker-fuse
shrinking /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/bin/dislocker-file
shrinking /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/bin/dislocker-metadata
shrinking /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/bin/dislocker-bek
gzipping man pages under /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/lib  /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1/bin
patching script interpreter paths in /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1
checking for references to /build in /nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1...
/nix/store/54xgx119b5976x49gcj14jr2gj17r8v1-dislocker-0.7.1

@fpletz fpletz merged commit 6d6d93c into NixOS:master Mar 12, 2018
@xeji xeji deleted the dislocker branch March 12, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @elitak @GrahamcOfBorg @fpletz