Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errbot: fix build #36701

Closed
wants to merge 1 commit into from
Closed

errbot: fix build #36701

wants to merge 1 commit into from

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 9, 2018

Motivation for this change

Build was broken due to version restrictions requiring older versions of cryptography and pyOpenSSL. These restrictions are not needed with python >= 3.4, removed.

/cc ZHF #36453
/cc maintainers @fpletz @globin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Was broken because of version restrictions for dependencies
cryptography and pyOpenSSL that are not needed for python >= 3.4.
@xeji
Copy link
Contributor Author

xeji commented Mar 10, 2018

fixed in 679580b , closing

@xeji xeji closed this Mar 10, 2018
@xeji xeji deleted the errbot branch March 10, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants