xautolock: implement basic test to confirm functionality #36706

Ma27 · 2018-03-09T23:09:03Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Ma27 · 2018-03-09T23:09:18Z

/cc @grahamc

Ma27 · 2018-03-13T17:30:18Z

ok, I'm confused. Did I screw something up or does this seem to be a bug of the bot?

7c6f434c · 2018-03-13T17:40:37Z

@grahamc Have we used ofborg for any tests since evaluation checks have landed?

grahamc · 2018-03-13T17:54:28Z

I don't think so... seems like a bug. Looking.

grahamc · 2018-03-13T18:05:40Z

Nope, the problem is with the test:

$ HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.xautolock --option restrict-eval true --option build-timeout 1800 --arg supportedSystems '["x86_64-linux"]'
error: anonymous function at /home/grahamc/projects/nixpkgs/nixos/tests/xautolock.nix:1:25 called with unexpected argument 'system', at /home/grahamc/projects/nixpkgs/nixos/tests/make-test.nix:5:41

After:

diff --git a/nixos/tests/xautolock.nix b/nixos/tests/xautolock.nix
index 38ba668e00e..ee46d9e05b0 100644
--- a/nixos/tests/xautolock.nix
+++ b/nixos/tests/xautolock.nix
@@ -1,4 +1,4 @@
-import ./make-test.nix ({ pkgs, lib }:
+import ./make-test.nix ({ pkgs, lib, ... }:
 
 with lib;

it works:

[nix-shell:~/projects/nixpkgs]$ HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.xautolock --option restrict-eval true --option build-timeout 1800 --arg supportedSystems '["x86_64-linux"]'
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/qp2j5p486avf4m55d1mdgpbx8nv7l0gm-vm-test-run-xautolock.drv

grahamc · 2018-03-13T18:12:16Z

TODO: Publish the logs from a failed evaluation :D

Ma27 · 2018-03-13T20:05:57Z

ahh thx, sorry for this (tested it with nix-build ./nixos/tests/xautolock.nix and it successfully built)

Ma27 · 2018-03-13T20:21:06Z

just to confirm, the command you used worked perfectly fine for me:

→ HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.xautolock --option restrict-eval true --option build-timeout 1800 --arg supportedSystems '["x86_64-linux"]' 
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/vdgqdgb3m4c7gqgls38nn3d9ki4ldnr3-vm-test-run-xautolock.drv

I unfortunately lack some inside knowledge of our testing bot, but please let me know if there's anything I can do to resolve this issue.

grahamc · 2018-03-13T20:22:00Z

OK I've identified the problem:

[root@builder-0-gustav:/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci]# HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.xautolock --option restrict-eval true --option build-timeout 1800 --arg supportedSystems '["x86_64-linux"]'
error: assertion failed at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/pkgs/build-support/closure-info.nix:11:1
(use ‘--show-trace’ to show detailed location information)

In other words, I forgot to use Nix 2 on these boxes. Please hold.

grahamc · 2018-03-13T20:23:07Z

FWIW here is the ongoing log for aarch64: https://logs.nix.ci/?attempt_id=e0e77309-9366-42f0-a004-5a07868fccea&key=nixos%2Fnixpkgs.36706

grahamc · 2018-03-13T20:26:34Z

Changed the nix package in a new place ...

@GrahamcOfBorg test xautolock

grahamc · 2018-03-13T20:27:03Z

Mar 13 20:26:49 builder-0-gustav.ewr1.nix.ci ofborg-builder-start[22293]: Can build: tests.xautolock, Cannot build:

Progress!

GrahamcOfBorg · 2018-03-13T20:33:10Z

Success on x86_64-linux (full log)

Attempted: tests.xautolock

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 143.10s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/8adqvwp3m5vlxj5va78g2rgdsw814isp-vm-test-run-xautolock

GrahamcOfBorg · 2018-03-13T20:35:43Z

Failure on aarch64-linux (full log)

Attempted: tests.xautolock

Partial log (click to expand)

machine: running command: journalctl -b SYSLOG_IDENTIFIER=systemd | grep 'session opened'
machine: exit status 1
error: action timed out after -1 seconds at /nix/store/vhy2am16zcdlav555dbdf7rjdb8786l9-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 227, <__ANONIO__> line 901.
action timed out after -1 seconds at /nix/store/vhy2am16zcdlav555dbdf7rjdb8786l9-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 227, <__ANONIO__> line 901.
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/738paar0hwyyyk9rh8hi2y894f4vwj4n-vm-test-run-xautolock.drv' failed with exit code 255
�[31;1merror:�[0m build of '/nix/store/738paar0hwyyyk9rh8hi2y894f4vwj4n-vm-test-run-xautolock.drv' failed

grahamc · 2018-03-13T20:36:11Z

OK So this seems good. It is failing on aarch64, but no need to block this PR on it I think.

GrahamcOfBorg · 2018-03-13T20:38:54Z

Success on x86_64-linux (full log)

Attempted: tests.xautolock

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 142.89s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/jdpcb4rlh8lhlif2rp250y53nw0ns9j4-vm-test-run-xautolock

Ma27 · 2018-03-13T20:40:23Z

well, as it breaks at journalctl -b SYSLOG_IDENTIFIER=systemd | grep 'session opened' it's likely that the actual issue on aarch64 is related to $machine->waitForX;.

And thanks a lot for your support <3

grahamc · 2018-03-13T20:43:30Z

Indeed:

machine# [   18.543456] display-manager[642]: (WW) Falling back to old probe method for modesetting
machine# [   18.550807] display-manager[642]: (EE) open /dev/dri/card0: No such file or directory
machine# [   18.558055] display-manager[642]: (EE) No devices detected.
machine# [   18.563576] display-manager[642]: (EE)
machine# [   18.567755] display-manager[642]: Fatal server error:
machine# [   18.572923] display-manager[642]: (EE) no screens found(EE)
machine# [   18.578363] display-manager[642]: (EE)
machine# [   18.582023] display-manager[642]: Please consult the The X.Org Foundation support
machine# [   18.587597] display-manager[642]:    at http://wiki.x.org
machine# [   18.591699] display-manager[642]:  for help.
machine# [   18.595072] display-manager[642]: (EE) Please also check the log file at "/dev/null" for additional information.
machine# [   18.602529] display-manager[642]: (EE)
machine# [   18.605539] display-manager[642]: (EE) Server terminated with error (1). Closing log file.
machine# [   18.966152] display-manager[642]: Giving up.
machine# [   18.971057] display-manager[642]: slim: unable to connect to X server

GrahamcOfBorg · 2018-03-13T20:44:08Z

Failure on aarch64-linux (full log)

Attempted: tests.xautolock

Partial log (click to expand)

machine: running command: journalctl -b SYSLOG_IDENTIFIER=systemd | grep 'session opened'
machine: exit status 1
error: action timed out after -1 seconds at /nix/store/vhy2am16zcdlav555dbdf7rjdb8786l9-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 227, <__ANONIO__> line 901.
action timed out after -1 seconds at /nix/store/vhy2am16zcdlav555dbdf7rjdb8786l9-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 227, <__ANONIO__> line 901.
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/ggz1x8m35clpzws32lvj4xs308fcr786-vm-test-run-xautolock.drv' failed with exit code 255
�[31;1merror:�[0m build of '/nix/store/ggz1x8m35clpzws32lvj4xs308fcr786-vm-test-run-xautolock.drv' failed

grahamc · 2018-03-13T20:47:39Z

I think deleting my comments asking for the bot to run triggered the bot :')

Ma27 · 2018-03-13T22:56:38Z

thx! and thanks again for your help :)

Ma27 force-pushed the xautolock-testcase branch from 20fc6f1 to efc4fe3 Compare March 9, 2018 23:10

GrahamcOfBorg added 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 9, 2018

xautolock: implement basic test to confirm functionality

4f225f9

Ma27 force-pushed the xautolock-testcase branch from efc4fe3 to 4f225f9 Compare March 13, 2018 20:04

NixOS deleted a comment from GrahamcOfBorg Mar 13, 2018

grahamc merged commit 1a1abb3 into NixOS:master Mar 13, 2018

Ma27 deleted the xautolock-testcase branch March 13, 2018 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xautolock: implement basic test to confirm functionality #36706

xautolock: implement basic test to confirm functionality #36706

Ma27 commented Mar 9, 2018 •

edited

Ma27 commented Mar 9, 2018

Ma27 commented Mar 13, 2018

7c6f434c commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

Ma27 commented Mar 13, 2018

Ma27 commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

Ma27 commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

grahamc commented Mar 13, 2018

Ma27 commented Mar 13, 2018

xautolock: implement basic test to confirm functionality #36706

xautolock: implement basic test to confirm functionality #36706

Conversation

Ma27 commented Mar 9, 2018 • edited

Motivation for this change

Things done

Ma27 commented Mar 9, 2018

Ma27 commented Mar 13, 2018

7c6f434c commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

Ma27 commented Mar 13, 2018

Ma27 commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

Ma27 commented Mar 13, 2018

grahamc commented Mar 13, 2018

GrahamcOfBorg commented Mar 13, 2018

grahamc commented Mar 13, 2018

Ma27 commented Mar 13, 2018

Ma27 commented Mar 9, 2018 •

edited