chromium: fix GCC 7 related build issues #36690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, it still seems to fail. Adding another patch. |
YorikSar
force-pushed
the
fix-chromium-build
branch
from
d7ad0a7
to
f541375
Compare
Also clean up unused patches.
YorikSar
force-pushed
the
fix-chromium-build
branch
from
f541375
to
ebce421
Compare
YorikSar
referenced
this pull request
Mar 9, 2018
see https://chromereleases.googleblog.com/2018/03/stable-channel-update-for-desktop.html cc @aszlig @YorikSar CVE-2017-11215 CVE-2017-11225 CVE-2018-6060 CVE-2018-6061 CVE-2018-6062 CVE-2018-6057 CVE-2018-6063 CVE-2018-6064 CVE-2018-6065 CVE-2018-6066 CVE-2018-6067 CVE-2018-6068 CVE-2018-6069 CVE-2018-6070 CVE-2018-6071 CVE-2018-6072 CVE-2018-6073 CVE-2018-6074 CVE-2018-6075 CVE-2018-6076 CVE-2018-6077 CVE-2018-6078 CVE-2018-6079 CVE-2018-6080 CVE-2018-6081 CVE-2018-6082 CVE-2018-6083
|
@7c6f434c thanks! Can you please also cherrypick this commit to stable branches? |
|
OK, wow, there were a lot of missing pieces in this release. Thanks for taking care of this, @YorikSar |
|
@bendlas It seems only next release will be ready for GCC 7.3, but we are already there. |
7c6f434c
added a commit
that referenced
this pull request
Mar 10, 2018
chromium: fix GCC 7 related build issues (cherry picked from commit cac24cc)
7c6f434c
added a commit
that referenced
this pull request
Mar 10, 2018
chromium: fix GCC 7 related build issues (cherry picked from commit cac24cc)
|
As you say, oh Chromium guru. |
|
@7c6f434c thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Chromium build has been failing.
Most of the issues were related to GCC update, all of them have been fixed upstream. I've added several commits that need to be applied to stable and dev. Beta is currently older that stable, so I didn't look at it.
Also removed
fix_network_api_crash.patchand replaced it with proper commit from upstream.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc @bendlas