Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JDK 9 and Eclipse to GTK 3 #36703

Closed
wants to merge 2 commits into from
Closed

Update JDK 9 and Eclipse to GTK 3 #36703

wants to merge 2 commits into from

Conversation

jerith666
Copy link
Contributor

Motivation for this change

Eclipse's built-in browser wants webkitgtk, but the current version of webkitgtk in nixpkgs is built on gtk3. So, we need a version of the JDK that's built on gtk3 as well.

I've run with this for a couple of days at work and not noticed any problems with Eclipse. I also confirmed that jconsole, a swing app bundled with the JDK, works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jerith666
openjdk9: gtk2 -> gtk3
d806f50 
http://openjdk.java.net/jeps/283 "Enable GTK 3 on Linux" was included
in OpenJDK 9.

nothing else currently in nixpkgs is using 9, so this just lets us
establish a good baseline as things are ported onto it.  if needed,
the build could be parameterized so that any packages that turn out to
need gtk2 could still use it.
@jerith666
eclipse: jdk8 -> jdk9
c91ffea 
in combination with the parent commit that makes jdk9 use gtk3, this
lets us get onto a current webkitgtk.

since the current version of webkitgtk is still receiving security
updates, this also reverts 49ea0e2
"eclipse: Do not use webkitgtk2 by default".
@jerith666 jerith666 requested a review from rycee as a code owner March 9, 2018 22:39
@jerith666 jerith666 changed the title Update JDK and Eclipse to GTK 3 Update JDK 9 and Eclipse to GTK 3 Mar 10, 2018
@rycee
Copy link
Member

rycee commented Mar 10, 2018

Sweet stuff! Tried building it and Eclipse looks good! 👍

As far as I can tell this is good to be merged and maybe even backported to 18.03.

I can't say for certain about the jdk parts, though. @edwtjo?

@rycee
Copy link
Member

rycee commented Mar 24, 2018

@thoughtpolice Maybe you have some throught about moving jdk9 to gtk3?

@thoughtpolice
Copy link
Member

I think it would be fine to move jdk9 to gtk3+ personally (though I don't use a lot of the GTK/UX components admittedly, I often run headless). However, I think the jdk9 package is not really long for this world as it's been EOL'd.

But it would be nice not to drop this patch on the floor and force a rebase, provided it can build fine and downstream packages are OK.

I wonder if this makes any (noticeable) impact on closure size...

@jerith666
Copy link
Contributor Author

Perhaps it is pointless now that 10 is out and 9 is EOL'd; if you want me to close this and just open a PR to remove 9 entirely instead, I'm okay with that.

I have a similar patch for openjdk10 (jerith666@599071d), which I'll make a PR for as soon as #37870 is merged.

I've been on vacation the last couple of days, but once I'm back at work I plan to roll eclipse forward to 10 as well, and will report in the PR for 599071d how well that goes. I can also try to find some time to check the closure size too.

@fpletz
Copy link
Member

fpletz commented Mar 28, 2018

@jerith666 Sounds fine to me. Thanks! 👍

@fpletz fpletz closed this Mar 28, 2018
@rycee
Copy link
Member

rycee commented Mar 28, 2018

I may be difficult to reach the next few weeks but if the necessary changes to Eclipse are similar to the ones in this PR then I've love to get them in as soon as possible. Thanks a lot for taking the time to work on this @jerith666!

@thoughtpolice
Copy link
Member

@jerith666 You are awesome, thank you for the openjdk10 work! I wanted to get it in myself but hadn't found the time. I'll look into dropping JDK9 now honestly since it would be great to sort that out before the official 18.03 release...

@jerith666
Copy link
Contributor Author

Actually @NeQuissimus beat me to it by about 12 hours, you should thank him instead. :)

(What we came up with was basically identical, #37870 was all that differed. I stupidly didn't fetch before i started working on it ...)

Unless something has changed since I opened this PR, 9 is unused in nixpkgs, so dropping it should be trivial ...

... except that you need it to bootstrap building 10. :) (I tried bootstrapping with 8, but 10 refuses to build with a non-modular bootstrap JDK.) So, ideas on how to solve that are welcome. I'd rather not use the approach of out-of-tree bootstrap JDKs like was done for earlier versions if it can be helped ... but, maybe that's just academic since there's always gonna be some out-of-tree bootstrapper at the root ... ?

This was referenced Mar 30, 2018
Closed
Merged
@jerith666
Copy link
Contributor Author

#38397 is the Java 10 version of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jerith666 @rycee @thoughtpolice @fpletz @GrahamcOfBorg