Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Remove old version 1.8 #35350

Merged
merged 3 commits into from Feb 23, 2018
Merged

go: Remove old version 1.8 #35350

merged 3 commits into from Feb 23, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 22, 2018 •
edited

Motivation for this change

Follow up PR to #35327

According to https://golang.org/doc/devel/release.html#policy only the two latest releases are supported and 1.10 is out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc go maintainers @cstrahan @orivej @wkennington
cc perkeep maintainer @cstrahan
cc cockroachdb maintainer @rushmorem

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘cockroach-1.1.5’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/servers/sql/cockroachdb/default.nix:38 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

github.com/cockroachdb/cockroach/pkg/sql/jobs
github.com/cockroachdb/cockroach/pkg/ts
go build github.com/cockroachdb/cockroach/pkg/server/status: invalid flag in #cgo LDFLAGS: -u_je_zone_register
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun
github.com/cockroachdb/cockroach/pkg/sql/distsqlplan
make[1]: *** [Makefile:177: buildoss] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-cockroach-1.1.5.drv-0/go/src/github.com/cockroachdb/cockroach/src/github.com/cockroachdb/cockroach'
make: *** [Makefile:3: buildoss] Error 2
builder for '/nix/store/ph5kbil0nxxx6p6009b9z0h5lfy3vx21-cockroach-1.1.5.drv' failed with exit code 2
error: build of '/nix/store/ph5kbil0nxxx6p6009b9z0h5lfy3vx21-cockroach-1.1.5.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin
shrinking /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin/bin/cockroach
gzipping man pages under /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin/bin 
patching script interpreter paths in /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin
checking for references to /tmp/nix-build-cockroach-1.1.5.drv-0 in /nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin...
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
/nix/store/x65nnf9bzv8lmia0sh6arg79bipsabwr-cockroach-1.1.5-bin
/nix/store/p0a1pdgrdhmyrsm8rr0gxdv74ip01zq3-perkeep-20170505

@fpletz fpletz added this to the 18.03 milestone Feb 22, 2018
@adisbladis adisbladis merged commit 0b3a5b5 into NixOS:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @GrahamcOfBorg @fpletz