nixos: properly disable sound by default, if stateVersion > 18.03 #35366
Conversation
oxij
force-pushed
the
pull/35355-no-sound-v2
branch
from
ab6b130
to
1957e8b
Compare
oxij
force-pushed
the
pull/35355-no-sound-v2
branch
from
1957e8b
to
f0816cf
Compare
| @@ -21,7 +21,8 @@ in | |||
|
|
|||
| enable = mkOption { | |||
| type = types.bool; | |||
| default = true; | |||
| default = !versionAtLeast config.system.stateVersion "18.03"; | |||
There was a problem hiding this comment.
Not sure about this in combination with defaultText, but this might cause a rebuild of the NixOS manual. Have you checked that?
There was a problem hiding this comment.
I did not check that. But if does cause a rebuild
- it doesn't really matter, as its just a single rebuild per release,
- its a bug that can surely be fixed.
|
Maybe just quietly rebase it to add all the warnings? I don't use any NixOS-derived code for sound configuration |
|
Any updates on this pull request, please? |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
Closing because 18.03 is pretty old. |
Motivation for this change
#35355 done properly:
The change to
libis somewhat ugly because the original impl is and other places innixosdepend on those functions and their semantics. I made a minimal possible change that doesn't break anything existing. Lets refactor (and break custom.mergefor custom types) later if anyone cares.Closes #35319 and closes #35355.
Things done
build-use-sandboxinnix.confon non-NixOS)