Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting one include of median from BOOST library to arithmetics_counter file #3189

Merged
merged 2 commits into from Feb 23, 2018

Conversation

victor-ludorum
Copy link
Contributor

Two times "#include <boost/accumulators/statistics/median.hpp>" is included. So, one should be removed .
@hkaiser Would you mind to review !!

Two times "#include <boost/accumulators/statistics/median.hpp>" is included. So, one should be removed .
@victor-ludorum victor-ludorum changed the title Deleting one include of median from BOOST Deleting one include of median from BOOST library to arithmetics_counter file Feb 22, 2018
@hkaiser hkaiser added this to the 1.1.0 milestone Feb 22, 2018
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have removed the wrong of the two #includes. As a result the #pragma's are left without purpose.

Two times "#include <boost/accumulators/statistics/median.hpp>" is included. So, one should be removed .
Verified
@victor-ludorum
Copy link
Contributor Author

@hkaiser Sir, I have updated it . Sorry, I haven't recognized that previously.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg msimberg merged commit 64c1337 into STEllAR-GROUP:master Feb 23, 2018
@victor-ludorum victor-ludorum deleted the include/median-twice branch February 23, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants