Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SABnzbd 2.3.2 #35336

Closed
wants to merge 3 commits into from
Closed

SABnzbd 2.3.2 #35336

wants to merge 3 commits into from

Conversation

bflyblue
Copy link
Contributor

@bflyblue bflyblue commented Feb 22, 2018 •
edited

Motivation for this change

New stable version of SABnzbd.
Added the sabyenc module which is a new (optional) dependency in SABnzbd 2.0+

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bflyblue bflyblue requested a review from FRidh as a code owner February 22, 2018 14:15
FRidh
FRidh requested changes Feb 22, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering sabyenc is a fork specifically for sabnzbd, can you move that expression to the sabnzbd expression. Other than that it looks good.

@FRidh
Copy link
Member

FRidh commented Feb 22, 2018

Note it needs to be tested before merging.

@bflyblue
Copy link
Contributor Author

Thank you, I'll move the sabyenc expression and test locally.

@bflyblue
Copy link
Contributor Author

I've made the requested change. I'm still relatively new to nix, would you mind checking I've done it correctly and help with testing? It at least works for me on my system.

@bflyblue
Copy link
Contributor Author

I've tested this on NixOS over the past few days and it's working correctly for me.

@FRidh FRidh self-assigned this Mar 1, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 28, 2018

Closing this since it has been superseded:

@c0bw3b c0bw3b closed this Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees

@FRidh FRidh

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bflyblue @FRidh @c0bw3b @GrahamcOfBorg