chkcrontab: init at 1.7 #35347

Ma27 · 2018-02-22T16:31:17Z

Motivation for this change

chkcrontab is a simple utility to check crontab for errors.
Fixes #34969

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda

The expression belongs into pkgs/tools/... and buildPythonApplication should be used. It should be called from all-packages.nix.

fpletz · 2018-02-23T03:06:34Z

pkgs/development/python-modules/chkcrontab/default.nix

@@ -0,0 +1,18 @@
+{ buildPythonPackage, stdenv, fetchPypi }:
+
+buildPythonPackage rec {


buildPythonApplication

Ma27 · 2018-02-24T10:13:08Z

@fpletz @dotlambda thanks for the feedback. However I won’t have any laptop to code until tuesday evening, I can fix it then :)

Ma27 · 2018-02-28T11:03:12Z

@dotlambda @fpletz done :)

dotlambda

Two final changes, then it's good to go.

dotlambda · 2018-02-28T11:06:56Z

pkgs/tools/chkcrontab/default.nix

+    description = "A tool to detect crontab errors";
+    license = licenses.asl20;
+    maintainers = with maintainers; [ ma27 ];
+    homepage = https://pypi.python.org/pypi/chkcrontab;


https://github.com/lyda/chkcrontab

dotlambda · 2018-02-28T11:09:50Z

pkgs/top-level/all-packages.nix

@@ -1531,6 +1531,8 @@ with pkgs;

  checkinstall = callPackage ../tools/package-management/checkinstall { };

+  chkcrontab = callPackage ../tools/chkcrontab { };


Please move to tools/admin sor something like that

dotlambda · 2018-03-04T23:48:07Z

pkgs/top-level/all-packages.nix

@@ -608,6 +608,8 @@ with pkgs;

  container-linux-config-transpiler = callPackage ../development/tools/container-linux-config-transpiler { };

+  chkcrontab = callPackage ../tools/chkcrontab { };


Please choose a subdir of tools/

dotlambda · 2018-03-04T23:48:45Z

@GrahamcOfBorg build chkcrontab

GrahamcOfBorg · 2018-03-05T00:03:06Z

Success on aarch64-linux (full log)

Partial log (click to expand)

W: 19: @monthly Missing User
w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.
/nix/store/rqgn641k09hz63j7cjm5v8jxm83h2ww4-chkcrontab-1.7

GrahamcOfBorg · 2018-03-05T02:34:53Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.
builder for ‘/nix/store/piwgdg0zv67hq13kfnjgx5bn1asvgdj5-chkcrontab-1.7.drv’ failed with exit code 1
error: build of ‘/nix/store/piwgdg0zv67hq13kfnjgx5bn1asvgdj5-chkcrontab-1.7.drv’ failed

`chkcrontab` is a simple utility to check crontab for errors. Fixes NixOS#34969

Ma27 · 2018-03-05T15:45:27Z

@dotlambda I fixed the issue. However I'm confused about the error message, when I run nix-build -A chkcrontab --option build-use-sandbox true works perfectly fine...

dotlambda · 2018-03-05T15:48:08Z

What did you change?

dotlambda · 2018-03-05T15:52:14Z

@GrahamcOfBorg build chkcrontab

GrahamcOfBorg · 2018-03-05T15:53:21Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.
builder for ‘/nix/store/piwgdg0zv67hq13kfnjgx5bn1asvgdj5-chkcrontab-1.7.drv’ failed with exit code 1
error: build of ‘/nix/store/piwgdg0zv67hq13kfnjgx5bn1asvgdj5-chkcrontab-1.7.drv’ failed

GrahamcOfBorg · 2018-03-05T15:57:16Z

Success on aarch64-linux (full log)

Partial log (click to expand)

W: 19: @monthly Missing User
w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.
/nix/store/rqgn641k09hz63j7cjm5v8jxm83h2ww4-chkcrontab-1.7

Ma27 · 2018-03-05T16:06:41Z

@dotlambda I didn't change any of the logic, nix-build passes locally...
optionally we can disable the affected test case...

Ma27 · 2018-03-05T18:13:59Z

@grahamc could you please have a short look at the borg's output? I tried the sandbox build successfully and I don't know if I managed to screw something up or that's a bug of @GrahamcOfBorg :)

Ma27 · 2018-03-17T12:39:12Z

@GrahamcOfBorg build chkcrontab

dotlambda · 2018-03-18T09:21:20Z

@GrahamcOfBorg build chkcrontab

GrahamcOfBorg · 2018-03-18T09:21:59Z

Success on aarch64-linux (full log)

Attempted: chkcrontab

Partial log (click to expand)

w:     BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: 19: @monthly Missing User
w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.

GrahamcOfBorg · 2018-03-18T09:21:59Z

Success on x86_64-linux (full log)

Attempted: chkcrontab

Partial log (click to expand)

w:     BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: 19: @monthly Missing User
w:     USER_NOT_FOUND: User "Missing" not found.
E: There were 2 errors and 3 warnings.
See http://goo.gl/7XS9q for more info.
W: Cron will not process this file - its name must match [A-Za-z0-9_-]+ .
W: 5: 1 * * * * not_a_user Command with %
w:    BARE_PERCENT: A bare % is a line break in crontab and is commonly not intended.
W: There were 2 warnings.
See http://goo.gl/7XS9q for more info.

Ma27 · 2018-03-18T09:28:39Z

interesting... I actually added myself to the known users: NixOS/ofborg@b00ab5a

Ma27 requested a review from FRidh as a code owner February 22, 2018 16:31

Ma27 force-pushed the package-chkcrontab branch from 746ce24 to d24a848 Compare February 22, 2018 16:31

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 22, 2018

dotlambda requested changes Feb 22, 2018

View reviewed changes

fpletz reviewed Feb 23, 2018

View reviewed changes

dotlambda self-assigned this Feb 27, 2018

Ma27 force-pushed the package-chkcrontab branch from d24a848 to 86cf492 Compare February 28, 2018 11:03

GrahamcOfBorg removed the 6.topic: python label Feb 28, 2018

dotlambda requested changes Feb 28, 2018

View reviewed changes

Ma27 force-pushed the package-chkcrontab branch from 86cf492 to 6685dff Compare February 28, 2018 12:20

dotlambda reviewed Mar 4, 2018

View reviewed changes

chkcrontab: init at 1.7

8ed04b9

`chkcrontab` is a simple utility to check crontab for errors. Fixes NixOS#34969

Ma27 force-pushed the package-chkcrontab branch from 6685dff to 8ed04b9 Compare March 5, 2018 13:09

dotlambda merged commit b96fa84 into NixOS:master Mar 18, 2018

Ma27 deleted the package-chkcrontab branch March 18, 2018 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chkcrontab: init at 1.7 #35347

chkcrontab: init at 1.7 #35347

Ma27 commented Feb 22, 2018 •

edited

dotlambda left a comment

fpletz Feb 23, 2018

Ma27 commented Feb 24, 2018

Ma27 commented Feb 28, 2018

dotlambda left a comment

dotlambda Feb 28, 2018

dotlambda Feb 28, 2018

dotlambda Mar 4, 2018

dotlambda commented Mar 4, 2018

GrahamcOfBorg commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

Ma27 commented Mar 5, 2018

dotlambda commented Mar 5, 2018

dotlambda commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

Ma27 commented Mar 5, 2018

Ma27 commented Mar 5, 2018

Ma27 commented Mar 17, 2018

dotlambda commented Mar 18, 2018

GrahamcOfBorg commented Mar 18, 2018

GrahamcOfBorg commented Mar 18, 2018

Ma27 commented Mar 18, 2018

		@@ -0,0 +1,18 @@
		{ buildPythonPackage, stdenv, fetchPypi }:

		buildPythonPackage rec {

		@@ -1531,6 +1531,8 @@ with pkgs;

		checkinstall = callPackage ../tools/package-management/checkinstall { };

		chkcrontab = callPackage ../tools/chkcrontab { };

		@@ -608,6 +608,8 @@ with pkgs;

		container-linux-config-transpiler = callPackage ../development/tools/container-linux-config-transpiler { };

		chkcrontab = callPackage ../tools/chkcrontab { };

chkcrontab: init at 1.7 #35347

chkcrontab: init at 1.7 #35347

Conversation

Ma27 commented Feb 22, 2018 • edited

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

fpletz Feb 23, 2018

Choose a reason for hiding this comment

Ma27 commented Feb 24, 2018

Ma27 commented Feb 28, 2018

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda Feb 28, 2018

Choose a reason for hiding this comment

dotlambda Feb 28, 2018

Choose a reason for hiding this comment

dotlambda Mar 4, 2018

Choose a reason for hiding this comment

dotlambda commented Mar 4, 2018

GrahamcOfBorg commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

Ma27 commented Mar 5, 2018

dotlambda commented Mar 5, 2018

dotlambda commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

GrahamcOfBorg commented Mar 5, 2018

Ma27 commented Mar 5, 2018

Ma27 commented Mar 5, 2018

Ma27 commented Mar 17, 2018

dotlambda commented Mar 18, 2018

GrahamcOfBorg commented Mar 18, 2018

GrahamcOfBorg commented Mar 18, 2018

Ma27 commented Mar 18, 2018

Ma27 commented Feb 22, 2018 •

edited