Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: 1.7.11 -> 1.8.2 #35342

Merged
merged 1 commit into from Feb 22, 2018
Merged

electron: 1.7.11 -> 1.8.2 #35342

merged 1 commit into from Feb 22, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Feb 22, 2018 •
edited

Motivation for this change

Needed for #35334

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@manveru
Copy link
Contributor Author

manveru commented Feb 22, 2018

I can confirm that Rambox at least starts up fine. Also added the arm64 version.

@manveru manveru force-pushed the upgrade-electron branch 2 times, most recently from ae596ca to af5e197 Compare February 22, 2018 17:19
@manveru
Copy link
Contributor Author

manveru commented Feb 22, 2018

amended.

@manveru
Copy link
Contributor Author

manveru commented Feb 22, 2018

Alright, did that as well as squash everything into a single commit again. Hope it builds now :)

@aristidb aristidb merged commit 823facf into NixOS:master Feb 22, 2018
@manveru manveru deleted the upgrade-electron branch December 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @aristidb @GrahamcOfBorg