Optionally disable printing of diagnostics during terminate. #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the call to std::abort in the termination handler as the system is aborting anyways.
|
Out of curiosity, what's the original problem this PR is addressing? |
If you work with Python loading modules that depend on HPX, then forcefully existing the python interpreter causes HPX to print the full debug info trace, which is just confusing. This allows to disable printing things, if required. |
sithhell
pushed a commit
that referenced
this pull request
Mar 13, 2018
This abort was removed with #3188.
sithhell
pushed a commit
that referenced
this pull request
Mar 15, 2018
This abort was removed with #3188.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the call to std::abort in the termination handler as the system is aborting anyways.