LB:316: replace ERROR_RETRY_DELAY with self.ERROR_RETRY_DELAY in influx_writer.py #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uditgulati
changed the title
|
the ticket also has a comment about @paramsingh any ideas on how we could test this? There are enough python tools to hack the time module to make sleeps not happen. You can use mock to make a constructor raise an exception once and succeed the second time. |
|
@alastair didn't see the comment earlier. I'll add it in this PR. |
|
I'm confused by this -- I don't see either where this is defined or imported. What am I missing? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
influx_writer.py checks in a number of places for configuration items, and if they don't exist it tries to sleep and then try again, however it sometime tries to sleep for ERROR_RETRY_DELAY seconds instead of self.ERROR_RETRY_DELAY