Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepass: fix auto-type and clipboard features #35344

Merged
merged 1 commit into from Feb 23, 2018

Conversation

svsdep
Copy link
Contributor

@svsdep svsdep commented Feb 22, 2018

Motivation for this change

This fixes paths to xdotool, xprop and xsel. These are required tools for auto-type to work correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This fixes paths to `xdotool`, `xprop` and `xsel`. These are required
tools for auto-type to work correctly.
@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

@GrahamcOfBorg build keepass

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘mono-4.0.4.1’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/mono/generic.nix:90 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38 /tmp/nix-build-keepass-2.38.drv-0
/tmp/nix-build-keepass-2.38.drv-0
Created /nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38/lib/pkgconfig/KeePassLib.pc
rscFileExt=ico
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38
patching script interpreter paths in /nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38
checking for references to /tmp/nix-build-keepass-2.38.drv-0 in /nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38...
/nix/store/p8jy1cwydfcpdkpbzwhf5ih79mbdi98y-keepass-2.38

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘xdotool-3.20160805.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/X11/xdotool/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@fpletz fpletz merged commit eba3572 into NixOS:master Feb 23, 2018
@svsdep svsdep deleted the keepass-xdotool branch February 25, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants