Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.broadcom-sta: fix build with Linux 4.15 #35346

Merged
merged 1 commit into from Feb 23, 2018
Merged

linuxPackages.broadcom-sta: fix build with Linux 4.15 #35346

merged 1 commit into from Feb 23, 2018

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Feb 22, 2018 •
edited

See: https://lkml.org/lkml/2017/11/25/90
(cherry picked from commit 6518772)

Fixes #35323

Motivation for this change

Backport from master, works fine on 17.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar YorikSar mentioned this pull request Feb 22, 2018
Closed
fpletz
fpletz approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@fpletz fpletz merged commit 8bce347 into NixOS:release-17.09 Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YorikSar @fpletz @GrahamcOfBorg @lukateras