Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox: 1.28.0 -> 1.28.1 #35363

Merged
merged 1 commit into from Feb 22, 2018
Merged

busybox: 1.28.0 -> 1.28.1 #35363

merged 1 commit into from Feb 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 22, 2018

Minor bump but one fix does impact our sandbox shell:
https://git.busybox.net/busybox/commit/?h=1_28_stable&id=59675c625d6500a9a0657481321954b0d1f63da9

You can try it with:

$ nix run -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz busybox-sandbox-shell -c busybox sh -c "shift 5 && echo eek"
eek
$

After this update:

$ nix run -f .  busybox-sandbox-shell -c busybox sh -c "shift 5 && echo eek"
$ # no eek printed

bootstrap tools testing seems good.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 22, 2018

Closely following musl bump in #35360 .

@dtzWill dtzWill merged commit 664cb08 into NixOS:master Feb 22, 2018
@dtzWill dtzWill deleted the update/busybox-1.28.1 branch February 22, 2018 21:05
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)


post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1
shrinking /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1/bin/busybox
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1/bin  /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1/sbin
patching script interpreter paths in /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1
checking for references to /build in /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1...
moving /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1/sbin/* to /nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1/bin
/nix/store/p2gffz96hgsarfaz20j3kdi9kvqvlsg1-busybox-1.28.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1
shrinking /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1/bin/busybox
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1/bin  /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1/sbin 
patching script interpreter paths in /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1
checking for references to /tmp/nix-build-busybox-1.28.1.drv-0 in /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1...
moving /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1/sbin/* to /nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1/bin
/nix/store/6mn4895gsmmnz3ayf5br4cbkik8xnb33-busybox-1.28.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘busybox-1.28.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/busybox/default.nix:100 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg