Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.vobject: 0.9.3 -> 0.9.5 #34696

Closed
wants to merge 1 commit into from
Closed

pythonPackages.vobject: 0.9.3 -> 0.9.5 #34696

wants to merge 1 commit into from

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Feb 7, 2018

Motivation for this change

I ran nox-review but it failed. Not sure if it's because of this change or whether those packages were broken anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 7, 2018 12:23
@jluttine
Copy link
Member Author

jluttine commented Feb 7, 2018

Hmm.. I'll rebase to master.

@jluttine
Copy link
Member Author

jluttine commented Feb 7, 2018

Oh, it was already updated in master but just wasn't moved to a separate file. Ok. this pull request is useless.

@jluttine jluttine closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @GrahamcOfBorg